Issue metadata
Sign in to add a comment
|
Stop alerting on malloc:effective_size when shim_allocated_objects_size becomes available |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8972297840828805584
,
Aug 3 2017
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: winx64_10_perf_bisect Benchmark : system_health.memory_desktop Metric : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_games/load_games_spychase Revision Result N chromium@489429 17434939 +- 1394739 21 good chromium@489540 17380006 +- 1347381 21 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.spychase system_health.memory_desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8972297840828805584 For feedback, file a bug with component Speed>Bisection
,
Aug 21 2017
WontFix-ing because bisect couldn't repro. +erikchen, perezju: this metric looks pretty noisy.
,
Aug 21 2017
> malloc:effective_size_avg Can we stop alerting on this metric for system_health.memory_desktop and memory.desktop? The metric shim_allocated_objects_size measures the same thing, but has 10x less noise.
,
Aug 21 2017
+ sullivan See c#5.
,
Aug 25 2017
perezju, primiano, hjd: Are you okay with #5?
,
Aug 26 2017
IIRC shim_allocated_objects_size requires heap profiling to be turned on[1] and we just turned heap profiling off for system_health.memory_desktop and memory.desktop because it was breaking a lot of the bots[2]. So I think we should at least wait till shim_allocated_objects_size is turned back on (currently blocked on the new out of process heap profiling). [1]: https://cs.chromium.org/chromium/src/base/trace_event/malloc_dump_provider.cc?type=cs&q=shim_allocated_objects_size&sq=package:chromium&l=313 [2]: https://bugs.chromium.org/p/chromium/issues/detail?id=757847
,
Aug 30 2017
Is there a bug open for fixing and re-enabling heap profiling on memory benchmarks? We should block this bug on that.
,
Aug 30 2017
,
Aug 30 2017
,
Dec 12 2017
Bisect unable to find culprit. This exists in stable. Ignoring. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 3 2017