New issue
Advanced search Search tips

Issue 751959 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

external/wpt/service-workers/service-worker/clients-matchall-client-types.https.html fails

Project Member Reported by falken@chromium.org, Aug 3 2017

Issue description

This is a testharness.js-based test.
FAIL Verify matchAll() with window client type assert_unreached: unexpected rejection: assert_array_equals: property 2, expected "https://web-platform.test:8444/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html" but got "https://web-platform.test:8444/service-workers/service-worker/resources/url-modified-via-pushstate.html" Reached unreachable code
FAIL Verify matchAll() with {window, sharedworker, worker} client types promise_test: Unhandled rejection with value: object "Error: wait_for_state must be passed a ServiceWorker"
Harness: the test ran to completion.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd2689c47c20ab508deb36033eab4e56b4d1d979

commit cd2689c47c20ab508deb36033eab4e56b4d1d979
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Aug 03 08:16:37 2017

Gardening: Unskip service-worker/clients-matchall-client-types.https.html

This test doesn't timeout anymore. It fails reliably. Add an expected file for
it.

As this was the final test linking to  bug 658997 , we can finally close the
bug.

TBR=shimazu

Bug:  658997 , 751959
Change-Id: I8acb6812a9c9c7824aa14d606a63ffbf7478f23e
Reviewed-on: https://chromium-review.googlesource.com/598661
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491675}
[modify] https://crrev.com/cd2689c47c20ab508deb36033eab4e56b4d1d979/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/cd2689c47c20ab508deb36033eab4e56b4d1d979/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt

Comment 2 by bke...@mozilla.com, Aug 3 2017

FWIW, I think there is another bug in this test.  In the "all" case it expects the result to be:

var expected_all_clients = [
    expected_only_window[0], expected_only_shared_worker[0],
    expected_only_dedicated_worker[0]
];

But the sort in the service worker will put "-dedicated-worker.js" ahead of "-iframe.html".  So this expectation seems wrong.

I'll make an upstream pull request for this.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
SW bug triage. Looks still available as we have -expected.txt that has two FAILs.

Sign in to add a comment