New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751958 link

Starred by 1 user
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

BookmarkAppUrlRedirectorBrowserTest.InAppNavigation fails

Project Member Reported by horo@chromium.org, Aug 3 2017 
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Ozone_Tests__1_%2F50696%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FBookmarkAppUrlRedirectorBrowserTest.InAppNavigation%2F0

[ RUN      ] BookmarkAppUrlRedirectorBrowserTest.InAppNavigation
[23405:23405:0802/220638.089134:4874005657:WARNING:diagnostics_writer.cc(209)] [FAIL] 008 PathUserData (Cannot obtain size for: /b/s/w/itU4tlrw/.org.chromium.Chromium.PrNAs8/dsK6C9Z)
[23405:23405:0802/220638.089230:4874005700:WARNING:diagnostics_writer.cc(209)] [FAIL] 007 PathLocalState (Path not found: /b/s/w/itU4tlrw/.org.chromium.Chromium.PrNAs8/dsK6C9Z/Local State)
[23405:23405:0802/220638.089333:4874005803:WARNING:diagnostics_writer.cc(209)] [FAIL] 013 JSONPreferences (File not found)
[23405:23405:0802/220638.089347:4874005818:WARNING:diagnostics_writer.cc(209)] [FAIL] 013 JSONLocalState (File not found)
[23405:23405:0802/220638.089370:4874005841:WARNING:diagnostics_writer.cc(209)] [FAIL] 002 SQLiteIntegrityWebData (File not found)
[23405:23405:0802/220638.089389:4874005859:WARNING:diagnostics_writer.cc(209)] [FAIL] 002 SQLiteIntegrityCookie (File not found)
[23405:23405:0802/220638.089415:4874005885:WARNING:diagnostics_writer.cc(209)] [FAIL] 002 SQLiteIntegrityHistory (File not found)
[23405:23405:0802/220638.090599:4874007070:WARNING:diagnostics_writer.cc(209)] Finished 18 tests.
[23405:23405:0802/220638.090619:4874007088:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Install type
[23405:23405:0802/220638.090627:4874007096:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Chrome version test
[23405:23405:0802/220638.090634:4874007103:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: User data path
[23405:23405:0802/220638.090641:4874007110:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Local state path
[23405:23405:0802/220638.090648:4874007117:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: App dictionaries directory path
[23405:23405:0802/220638.090655:4874007124:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Resources path
[23405:23405:0802/220638.090662:4874007131:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Available disk space
[23405:23405:0802/220638.090669:4874007138:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: User preferences integrity
[23405:23405:0802/220638.090677:4874007146:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Local state integrity
[23405:23405:0802/220638.090684:4874007153:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Bookmark file
[23405:23405:0802/220638.090691:4874007160:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Web Data database
[23405:23405:0802/220638.090698:4874007167:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Cookie database
[23405:23405:0802/220638.090705:4874007174:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Favicons database
[23405:23405:0802/220638.090712:4874007181:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: History database
[23405:23405:0802/220638.090719:4874007188:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Top Sites database
[23405:23405:0802/220638.090726:4874007195:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: Database tracker database
[23405:23405:0802/220638.090733:4874007202:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: NSS certificate database
[23405:23405:0802/220638.090740:4874007209:WARNING:diagnostics_writer.cc(209)] Finished Recovery for: NSS Key database
[23405:23405:0802/220638.090746:4874007215:WARNING:diagnostics_writer.cc(209)] Finished All Recovery operations.
[23405:23422:0802/220638.484137:WARNING:freezer_cgroup_process_manager.cc(62)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[23405:23483:0802/220638.674556:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /extensions/bookmark_apps/url_handlers/in_scope/index.html
[23405:23483:0802/220638.736589:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /extensions/bookmark_apps/url_handlers/in_scope/other.html
../../chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc:255: Failure
      Expected: out_of_scope_url
      Which is: http://127.0.0.1:59138/extensions/bookmark_apps/url_handlers/out_of_scope/other.html
To be equal to: app_browser->tab_strip_model() ->GetActiveWebContents() ->GetLastCommittedURL()
      Which is: http://127.0.0.1:59138/extensions/bookmark_apps/url_handlers/in_scope/other.html
[23405:23483:0802/220638.749521:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /extensions/bookmark_apps/url_handlers/out_of_scope/other.html
[  FAILED  ] BookmarkAppUrlRedirectorBrowserTest.InAppNavigation, where TypeParam =  and GetParam() =  (733 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60

commit 4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Aug 03 06:28:06 2017

Revert "desktop-pwas: Open Bookmark app when link is within scope"

This reverts commit aecc33fcc357fd232e5dbda7a4d03d3b0c3a8f5d.

Reason for revert: BookmarkAppUrlRedirectorBrowserTest.InAppNavigation fails

BUG:751958

Original change's description:
> desktop-pwas: Open Bookmark app when link is within scope
> 
> The DesktopPWAWindowing feature must be on in order for this to work.
> 
> Makes it so that, once a user has installed a Bookmark App for a website, all
> navigations to that website will open the installed Bookmark App. This includes
> typing the address in the omnibox, clicking any links to an in-scope url, and
> opening any links to an in-scope url from the context menu. Future patches
> will change some of these so that the result is more intuitive.
> 
> For example, if the user has installed https://www.foo.com through
> "Add to shelf" and the site's manifest defines scope as "/scope" and then the
> user visits https://www.foo.com/scope/test.html, a new app window to
> https://www.foo.com/scope/test.html will open. If the user
> navigated to https://www.foo.com/index.html, we would not open a new app
> window since the address is not in-scope as defined by the site's manifest.
> 
> Three changes:
> 
> 1. Use 'scope' in the site's manifest to create a url handler for
>    the bookmark app.
> 2. Allow Hosted Apps that are Bookmark apps to use url handlers.
>    This means that any non-bookmark hosted app that has url handlers
>    will fail to load.
> 3. When handling a url that a Bookmark app could handle open the
>    the bookmark app with the specified url.
> 
> Bug: 740783
> Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0
> Reviewed-on: https://chromium-review.googlesource.com/566199
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Sky Malice <skym@chromium.org>
> Reviewed-by: Matt Giuca <mgiuca@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491644}

TBR=benwells@chromium.org,calamity@chromium.org,mgiuca@chromium.org,ortuno@chromium.org,skym@chromium.org,jochen@chromium.org

Change-Id: I5e4bf4899d56fd2ffc1755b6cd5db0aa9c0c02d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 740783
Reviewed-on: https://chromium-review.googlesource.com/599090
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491662}
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/apps/app_url_redirector.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[delete] https://crrev.com/5d9135eee8b0e178efcd8b80e717f424fa8da677/chrome/browser/extensions/bookmark_app_url_redirector_browsertest.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/convert_web_app.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/convert_web_app.h
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/convert_web_app_unittest.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/extension_sync_data.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/extension_sync_data.h
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/browser/ui/extensions/application_launch.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/common/extensions/api/_manifest_features.json
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/common/extensions/api/url_handlers/url_handlers_parser.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/common/web_application_info.h
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/chrome/test/BUILD.gn
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/components/sync/protocol/app_specifics.proto
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/components/sync/protocol/proto_visitors.h
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/extensions/common/manifest_constants.cc
[modify] https://crrev.com/4d41d8cd4710e91fa82d2fcfadc55d0a0e089b60/extensions/common/manifest_constants.h

Comment 2 by ortuno@chromium.org, Aug 4 2017

Status: Fixed (was: Available)
►

Sign in to add a comment