New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751957 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X
Team-Accessibility

Blocked on:
issue 791391

Blocking:
issue 462133



Sign in to add a comment

AXPlatformNodeMac should support multiline labels for parameterised attributes

Project Member Reported by tapted@chromium.org, Aug 3 2017

Issue description

Chrome Version       : 62.0.3174.0
OS Version: OS X 10.13

Per Issue 743289, High Sierra has started asking for parameterised attributes on ui::AX_ROLE_STATIC_TEXT roles.

AXPlatformNodeMac gives correct results for single-line labels. However, it could previously assume that it would be backed by a views::Textfield, which is currently only single-line. So it will return incorrect results for mutli-line views::Labels.
 
Blockedon: 791391
Labels: MacViews-Controls
Owner: lgrey@chromium.org
This looks like it would involve actually implementing [AXPlatformNodeMac AXLineForIndex] and changing [AXPlatformNodeMac AXRangeForLine].

lgrey@, can you take a look at this? Thanks :)

Comment 4 by lgrey@chromium.org, Feb 8 2018

Labels: -Pri-2 Pri-3
Some notes:
- It's unclear how the OS supports this. In multi-line NSLabels, VO-l reads a single line ONLY if the label is in the process of being read. VO-up and VO-down ignore the lines.
- This is implemented for web content as BrowserAccessibility::GetLineStartOffsets (https://cs.chromium.org/chromium/src/content/browser/accessibility/browser_accessibility.cc?type=cs&l=805) which takes advantage of the fact that each line is a separate object
- The kLineBreaks (https://cs.chromium.org/chromium/src/ui/accessibility/ax_enums.mojom?type=cs&q=package:chromium&l=564) attribute can be used to implement this in Views but is currently slated for deprecation

Current thinking per offline discussions is that this should not block MacViews Secondary UI launch.

Comment 5 by lgrey@chromium.org, Feb 12 2018

Cc: nek...@chromium.org dtseng@chromium.org dmazz...@chromium.org
+ Accessibility folks re: kLineBreaks deprecation
Labels: Target-68
Mac triage: let's target this at M68.

Comment 7 by gov...@chromium.org, Apr 13 2018

Labels: Proj-MacViews
Labels: M-68

Comment 9 by gov...@chromium.org, Apr 25 2018

Pls mark the bug as fixed if CL is landed in trunk and nothing else is pending. Thank you.
Labels: -Target-68 Target-69
Labels: -M-68 Group-Accessibility
Labels: M-68
Labels: -M-68 M-69
Labels: -M-69 -Target-69 M-X

Sign in to add a comment