New issue
Advanced search Search tips

Issue 751952 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Sep 2017
Cc:
qyears...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove trailing whitespace in -expected.txt for testharness tests

Project Member Reported by tkent@chromium.org, Aug 3 2017 
What steps will reproduce the problem?
(1) Look at *-expected.txt files in //third_party/WebKit/LayotuTests/external/wpt/
  e.g. //third_party/WebKit/LayotuTests/external/wpt/dom/historical-expected.txt

What is the expected result?
No trailing whitespaces.

What happens instead?
There are a trailing space on each of PASS lines.

Please use labels and text to provide additional information.
Such whitespace is warned in Gerrit, git rebase, etc.

A code fix would be very simple. In add_completion_callback() of testharnessreport.js,

   sanitize(tests[i].message)

should be

   sanitize(tests[i].message.trim())

However, updating many -expected.txt would be troublesome.

Comment 1 by qyears...@chromium.org, Aug 7 2017

Cc: qyears...@chromium.org
Good idea; it might be good to do this after bug 679742 because that should take care of any trailing whitespace for testharness tests in wpt.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fb9fd31d5f4384271ae0ace68b80185829b8cc5

commit 3fb9fd31d5f4384271ae0ace68b80185829b8cc5
Author: Quinten Yearsley <qyearsley@google.com>
Date: Mon Aug 28 17:58:30 2017

Trim whitespace from message strings in testharnessreport

Bug:  751952 
Change-Id: Icdd37bb348a713c153fc2e6107613485ad160313
Reviewed-on: https://chromium-review.googlesource.com/625035
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497801}
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/accessibility/aria-slider-value.html
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/accessibility/name-calc-inputs-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/custom-properties/color-type-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/interpolation/border-image-width-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/interpolation/display-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/interpolation/list-style-image-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/interpolation/rotate-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/interpolation/webkit-mask-image-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/interpolation/z-index-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-d-composition-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-orient-composition-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-points-composition-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-transform-matrix-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-startOffset-interpolation-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/usecounters/step-middle-keyword-timing-function-deprecated-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/animations/usecounters/step-middle-timing-function-deprecated-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/bindings/dictionary-iterator-expected.txt
[delete] https://crrev.com/db7ead114a1f9a4bc601e1011ab90f587f3397e1/third_party/WebKit/LayoutTests/bluetooth/idl/idl-BluetoothDevice-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/bluetooth/idl/idl-BluetoothGATTRemoteServer-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/css3/device-adapt/opera/orientation-002-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/css3/flexbox/flexitem-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/css3/flexbox/style-change-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/css3/fonts/font-feature-settings-parsing-prefixed-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/css3/logical-props/logicalprops-quirklength-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/custom-elements/constructor-context-dies-cross-context-call-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/custom-elements/spec/create-element-defined-synchronous-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/custom-elements/spec/custom-elements-registry/when_defined-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/custom-elements/v0-v1-interop-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/custom-properties/register-property-syntax-parsing-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/editing/inserting/insert-html-crash.html
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/editing/selection/move-by-line-005.html
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/2d.drawImage.animated.poster-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-paths-to-the-canvas/canvas_focus_drawCustomFocusRing_001-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/drawing-text-to-the-canvas/2d.text.draw.fontface.notinpage-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/path-objects/2d.path.stroke.prune.arc-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/path-objects/2d.path.stroke.prune.closed-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/path-objects/2d.path.stroke.prune.curve-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/path-objects/2d.path.stroke.prune.line-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/path-objects/2d.path.stroke.prune.rect-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.create2.nonfinite-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.get.nonfinite-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.object.ctor.array.bounds-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/pixel-manipulation/2d.imageData.put.nonfinite-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.baseline.bottom-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.baseline.hanging-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.baseline.ideographic-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.baseline.middle-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.baseline.top-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.space.collapse.end-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.space.collapse.other-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.space.collapse.space-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.draw.space.collapse.start-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/2dcontext/text-styles/2d.text.measure.width.space-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-XHR-revoke-expected.txt
[delete] https://crrev.com/db7ead114a1f9a4bc601e1011ab90f587f3397e1/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-constructor-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/FileAPI/file/File-constructor-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/FileAPI/historical.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex15-autoincrement-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_ecdh_bits.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_hkdf.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_empty_empty.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_empty_long.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_empty_short.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/encrypt_decrypt/test_aes_cbc.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/encrypt_decrypt/test_aes_ctr.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/encrypt_decrypt/test_aes_gcm.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_aes-cbc.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_aes-ctr.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_failures.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_failures_AES-CBC.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_failures_AES-CTR.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_failures_AES-GCM.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_failures_AES-KW.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_successes_AES-CBC.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_successes_AES-CTR.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_successes_AES-GCM.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/generateKey/test_successes_AES-KW.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/idlharness-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/idlharness.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/import_export/test_symmetric_importKey.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebIDL/current-realm-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any.worker-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/interface-prototype-object-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/legacy-platform-object-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/sequence-conversion-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/abort-after-send-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/abort-during-upload-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/abort-event-order-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/access-control-and-redirects-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/data-uri-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/event-error-order.sub-expected.txt
[modify] https://crrev.com/3fb9fd31d5f4384271ae0ace68b80185829b8cc5/third_party/WebKit/LayoutTes
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339f48937f0f6e9e9af6c0dfbabd76c177fc690d

commit 339f48937f0f6e9e9af6c0dfbabd76c177fc690d
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Aug 30 04:37:12 2017

Follow-up to testharness EOL space stripping CL

Bug:  751952 ,  760186 
Change-Id: I76b4fc7ec70b1a5fe0309fd2cf9e924e1c8424f4
Reviewed-on: https://chromium-review.googlesource.com/639157
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498365}
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4026c5c9b67405b44855812e0cff0bfc6be2177d/third_party/WebKit/LayoutTests/external/wpt/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/audio-output/setSinkId.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/payment-request/historical.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-mime-types.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-scope.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-script-url.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-script.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-mime-types.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/android/harness-tests/wpt/console_logging-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/http/tests/devtools/console/console-format-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-mime-types.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-scope.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-script-url.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-script.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/registration-mime-types.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/devtools/console/console-uncaught-promise-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-mime-types.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-scope.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-script-url.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-script.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/registration-mime-types.https-expected.txt
[delete] https://crrev.com/4026c5c9b67405b44855812e0cff0bfc6be2177d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/external/wpt/uievents/auxclick/auxclick_event-manual-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac-retina/http/tests/devtools/console/console-format-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-mime-types.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-scope.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-script-url.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-script.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/registration-mime-types.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-mime-types.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-scope.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-script-url.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-script.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[add] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/registration-mime-types.https-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/win/editing/selection/modify_extend/extend_by_character-expected.txt
[modify] https://crrev.com/339f48937f0f6e9e9af6c0dfbabd76c177fc690d/third_party/WebKit/LayoutTests/platform/win/fast/dom/Range/getClientRects-expected.txt

Comment 4 by qyears...@chromium.org, Sep 1 2017

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57cbb3ae2a427e480cc68a1bba7fec3834428180

commit 57cbb3ae2a427e480cc68a1bba7fec3834428180
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Sep 11 15:52:31 2017

Rebaseline layout test .../link-element-register-security-error.https.html

This test still needed to be rebaselined after the
changes to the spaces in testharnessreport.js.

Bug:  751952 
Change-Id: I5e5d170de1fc25dffe0584e5b51a572fa08ed70e
Reviewed-on: https://chromium-review.googlesource.com/656145
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500924}
[modify] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[modify] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[copy] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[modify] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/platform/linux/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[delete] https://crrev.com/c812f15f4f9ac5635a4e9cf611d22877464c5c69/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[delete] https://crrev.com/c812f15f4f9ac5635a4e9cf611d22877464c5c69/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[modify] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-blobs/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[rename] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/platform/mac/virtual/outofblink-cors/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
[modify] https://crrev.com/57cbb3ae2a427e480cc68a1bba7fec3834428180/third_party/WebKit/LayoutTests/platform/mac/virtual/service-worker-script-streaming/external/wpt/service-workers/service-worker/link-element-register-security-error.https-expected.txt
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4585cfb357660e37d5a8426b485bc3c0bc73afb

commit a4585cfb357660e37d5a8426b485bc3c0bc73afb
Author: Will Chen <chenwilliam@chromium.org>
Date: Thu Dec 28 21:55:51 2017

DevTools: remove faulty rebaselines from wpt / testharness.js related cleanups

A handful of DevTools tests got platform-specific test expectations from CLs
related to wpt / testharness.js which shouldn't affect DevTools tests.

This removes platform-specific expectations where appropriate and rebaselines
the primary expectation. Some of these might actually not be flaky anymore
and will be followed-up once I review the new baselines on the flakiness dashboard.

Bug: 626703,  751952 
Change-Id: I898eb03c65c9fe35f9f9de499856e3e98290dbd3
Reviewed-on: https://chromium-review.googlesource.com/846026
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526329}
[modify] https://crrev.com/a4585cfb357660e37d5a8426b485bc3c0bc73afb/third_party/WebKit/LayoutTests/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt
[modify] https://crrev.com/a4585cfb357660e37d5a8426b485bc3c0bc73afb/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-expected.txt
[modify] https://crrev.com/a4585cfb357660e37d5a8426b485bc3c0bc73afb/third_party/WebKit/LayoutTests/http/tests/devtools/indexeddb/database-refresh-view.js
[modify] https://crrev.com/a4585cfb357660e37d5a8426b485bc3c0bc73afb/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-columns-visible-expected.txt
[modify] https://crrev.com/a4585cfb357660e37d5a8426b485bc3c0bc73afb/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/linux/http/tests/devtools/console/console-format-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/linux/http/tests/devtools/indexeddb/database-refresh-view-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/devtools/console/console-uncaught-promise-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac-mac10.11/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/mojo-loading/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac-retina/http/tests/devtools/console/console-format-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac-retina/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/mojo-loading/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac/http/tests/devtools/unit/datagrid-editable-longtext-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/devtools/application-panel/resources-panel-selection-on-reload-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/devtools/network/network-columns-visible-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/win/http/tests/devtools/indexeddb/database-refresh-view-expected.txt
[delete] https://crrev.com/2b38ceb8d26dfd7cd2607935e88ef31a81c38f78/third_party/WebKit/LayoutTests/platform/win7/http/tests/devtools/indexeddb/database-refresh-view-expected.txt
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1378ec8412b3a75df750acc22cdfe0a9adc211b5

commit 1378ec8412b3a75df750acc22cdfe0a9adc211b5
Author: Will Chen <chenwilliam@chromium.org>
Date: Tue Jan 02 21:27:59 2018

DevTools: remove rebaselined tests from TestExpectations

This is a follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/846026.
These tests were rebaselined and are now passing without flakes.

Bug: 626703,  751952 
Change-Id: I0497c373ae1b99e728b8f81cc52d11c9521e725e
Reviewed-on: https://chromium-review.googlesource.com/847309
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526536}
[modify] https://crrev.com/1378ec8412b3a75df750acc22cdfe0a9adc211b5/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e89eb17c67ef2a60e38029deb9640808953442e

commit 1e89eb17c67ef2a60e38029deb9640808953442e
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Wed Jul 04 12:33:54 2018

Remove failure expectations for some editing web platform tests

 Bug 751952  has been fixed a while ago, so I think we can remove the
failure expectation for the forwardDelete.html test.

Additionally, there are some comments in bug 698135 that indicate the
crash is not reproducible anymore, which was the reason why there
was a failure entry for the delete.html test.

This CL removes the related entries in the TestExpectations file and
provides a new expected file for the delete.html test. It keeps,
though, a Failure entry for Mac only in the case of the delete.html,
since there are clear interoperability issues with Mac for these use
cases.

BUG=698135

Change-Id: I973b84eb1ea19fa72ba4011001aa750b73e87b0c
Reviewed-on: https://chromium-review.googlesource.com/1124461
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572543}
[modify] https://crrev.com/1e89eb17c67ef2a60e38029deb9640808953442e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1e89eb17c67ef2a60e38029deb9640808953442e/third_party/WebKit/LayoutTests/external/wpt/editing/run/delete-expected.txt
►

Sign in to add a comment