New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751948 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

browser_tests failing on 3 builders

Project Member Reported by horo@chromium.org, Aug 3 2017

Issue description

browser_tests failing on 3 builders

Builders failed on: 
- Mac10.10 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests
- Mac10.11 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
- Mac10.12 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests




telemetry_perf_unittests
* measurements.multipage_skpicture_printer_unittest.MultipageSkpicturePrinterUnitTest.testSkpicturePrinter
* measurements.skpicture_printer_unittest.SkpicturePrinterUnitTest.testSkpicturePrinter

browser_tests
* ProcessMemoryMetricsEmitterTest.FetchDuringTrace
* ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics
* ProcessMemoryMetricsEmitterTest.FetchThreeTimes

telemetry_unittests
* telemetry.internal.actions.action_runner_unittest.ActionRunnerMeasureMemoryTest.testDeterministicMode
* telemetry.internal.actions.action_runner_unittest.ActionRunnerMeasureMemoryTest.testRealisticMode
* telemetry.internal.backends.chrome_inspector.tracing_backend_unittest.TracingBackendTest.testDumpMemorySuccess
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fd364a3566c39c2b47929a299682c8cb89df695

commit 1fd364a3566c39c2b47929a299682c8cb89df695
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Aug 03 05:08:52 2017

Revert "Make MetricsLog not need a PrefService."

This reverts commit 433d691752d8d327b99e5432c8f280e3f2ff8b83.

Reason for revert: Metrics related tests are failing. See  crbug.com/751948 


BUG:751948

Original change's description:
> Make MetricsLog not need a PrefService.
> 
> Move system profile persistence to MetricsService.
> 
> Bug: 
> Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0
> Reviewed-on: https://chromium-review.googlesource.com/592689
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491573}

TBR=bcwhite@chromium.org,holte@chromium.org,olivierrobin@chromium.org

Change-Id: Id9e35a2388566faf7681cddd34fdab9b83db0e03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/599089
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491649}
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_log.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_log.h
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_log_manager_unittest.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_log_store_unittest.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_service.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_service.h
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_service_unittest.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_state_manager.cc
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/components/metrics/metrics_state_manager.h
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/ios/chrome/today_extension/today_metrics_logger.h
[modify] https://crrev.com/1fd364a3566c39c2b47929a299682c8cb89df695/ios/chrome/today_extension/today_metrics_logger.mm

Comment 2 by horo@chromium.org, Aug 3 2017

Ah, the tests are failing even after #491573.
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/21659

Comment 3 by horo@chromium.org, Aug 3 2017

Relanding...
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f82d29421e1858066796d3be60fd16525e55b9e

commit 3f82d29421e1858066796d3be60fd16525e55b9e
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Aug 03 07:29:11 2017

Revert "Enable Finch Trial Test for MacV2Sandbox."

This reverts commit 3553b1fe42ecb18782876f185ebd03c08bfb8431.

Reason for revert: Caused browser_tests failures.
* ProcessMemoryMetricsEmitterTest.FetchDuringTrace
* ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics
* ProcessMemoryMetricsEmitterTest.FetchThreeTimes

Bug:751948

Original change's description:
> Enable Finch Trial Test for MacV2Sandbox.
> 
> Bug: 749839
> Change-Id: Ie95fc3c6574377e278474c1709b7270847016b44
> Reviewed-on: https://chromium-review.googlesource.com/596422
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Greg Kerr <kerrnel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491576}

TBR=jwd@chromium.org,kerrnel@chromium.org

Change-Id: I6e96580d4e0cd7f2d810187a9f4864748e9997d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749839
Reviewed-on: https://chromium-review.googlesource.com/599173
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491669}
[modify] https://crrev.com/3f82d29421e1858066796d3be60fd16525e55b9e/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0429a709949bdae77f579beb5c8dca41a16b6a1

commit d0429a709949bdae77f579beb5c8dca41a16b6a1
Author: Steven Holte <holte@google.com>
Date: Thu Aug 03 08:56:17 2017

Reland "Make MetricsLog not need a PrefService."

Sorry, I reverted wrong cl.

BUG:  751948 
TBR=bcwhite@chromium.org,holte@chromium.org,olivierrobin@chromium.org

This is a reland of 433d691752d8d327b99e5432c8f280e3f2ff8b83
Original change's description:
> Make MetricsLog not need a PrefService.
> 
> Move system profile persistence to MetricsService.
> 
> Bug: 
> Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0
> Reviewed-on: https://chromium-review.googlesource.com/592689
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491573}

Change-Id: Iea3ebc29e92f3e12fc56f7b7ba767c531f216041
Reviewed-on: https://chromium-review.googlesource.com/598759
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491684}
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_log.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_log.h
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_log_manager_unittest.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_log_store_unittest.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_service.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_service.h
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_service_unittest.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_state_manager.cc
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/components/metrics/metrics_state_manager.h
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/ios/chrome/today_extension/today_metrics_logger.h
[modify] https://crrev.com/d0429a709949bdae77f579beb5c8dca41a16b6a1/ios/chrome/today_extension/today_metrics_logger.mm

Comment 7 by gab@chromium.org, Aug 8 2017

Status: Fixed (was: Available)
Fixed by above reverts?

Sign in to add a comment