New issue
Advanced search Search tips

Issue 751945 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Introduce cached SelectionTemplate::IsBaseFirst()

Project Member Reported by yosin@chromium.org, Aug 3 2017 
SelectionTemplate::IsBaseFirst() has number of clients:
- SelectionForUndoStep::From(const SelectionInDOMTree&)
- Rewrite of VisibleSelection::Validate()

So, it is worth to have it.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50f5a150afb4fa7b1d5923d89b213d3d53dccd6c

commit 50f5a150afb4fa7b1d5923d89b213d3d53dccd6c
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Fri Aug 04 12:46:03 2017

Introduce SelectionTemplate::IsBaseFirst()

This patch Introduces |SelectionTemplate::IsBaseFirst()| and utilize it for
|Start()| and |End()| as preparation of make |SelectionForUndoStep::From()|
faster.

Bug:  751945 
Change-Id: I560c23bc6c4d72de3be3985fd6584805ac9e7da7
Reviewed-on: https://chromium-review.googlesource.com/598664
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492001}
[modify] https://crrev.com/50f5a150afb4fa7b1d5923d89b213d3d53dccd6c/third_party/WebKit/Source/core/editing/SelectionTemplate.cpp
[modify] https://crrev.com/50f5a150afb4fa7b1d5923d89b213d3d53dccd6c/third_party/WebKit/Source/core/editing/SelectionTemplate.h
[modify] https://crrev.com/50f5a150afb4fa7b1d5923d89b213d3d53dccd6c/third_party/WebKit/Source/core/editing/SelectionTemplateTest.cpp

Comment 2 by dtapu...@chromium.org, Dec 4 2017

Components: Blink>Editing
Status: Untriaged (was: Available)

Comment 3 by yosin@chromium.org, Dec 4 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment