New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751942 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Move WTF::TriState to core/editing

Project Member Reported by yosin@chromium.org, Aug 3 2017

Issue description

WTF::TriState is used only in core/editing and its name is too generic. We should rename it to EditingTriState.
 
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/766ada52e6b114eb6e614446c496bad36ad2abc9

commit 766ada52e6b114eb6e614446c496bad36ad2abc9
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Wed Sep 27 15:35:46 2017

Move WTF::TriState to core/editing

WTF::TriState is used only in core/editing.
So it is better to keep it inside core/editing.

Bug:  751942 
Change-Id: I62262240c6e39d8ed8108cb462262cd699490a71
Reviewed-on: https://chromium-review.googlesource.com/670206
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#504686}
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/BUILD.gn
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/EditingStyle.h
[rename] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/EditingTriState.h
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/commands/DocumentExecCommand.cpp
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/core/page/ContextMenuClient.cpp
[modify] https://crrev.com/766ada52e6b114eb6e614446c496bad36ad2abc9/third_party/WebKit/Source/platform/wtf/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment