Issue metadata
Sign in to add a comment
|
New UI has password field for Public Session pod in the sign-in screen |
||||||||||||||||||||||
Issue descriptionChrome Version: M61.0.3163.20 dev heli OS: ChromeOS What steps will reproduce the problem? (1) Enroll device in a OU where Public Session is enabled. What is the expected result? Public Session does not require login so no password is required in the pod in the sign in screen. What happens instead? Password field is seen in the PUblic Session pod in the sign in screen. After right after enrollment, old pod UI was displayed. After adding a user, the UI changed to the new design.
,
Aug 3 2017
I'm working on this. I haven't touched public session pod codes for a while.
,
Aug 3 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bad25d79920ef48c94769cbccf12d93d6e1a8e46 commit bad25d79920ef48c94769cbccf12d93d6e1a8e46 Author: Wenzhao Zang <wzang@chromium.org> Date: Tue Aug 08 07:11:34 2017 Cleans up old account picker use in OOBE Fixes the edge case in OOBE that may show the old UI for public session pods (see bug). It's not necessary to have a forked md_oobe.js because it works with the switch --show-no-md-login (which is used to display the old UI). 'oobe-shield' is replaced with 'login-shield' in oobe.js. Bug: 751922 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3ee32fed770efdac74e13e253aafecdafed6126f Reviewed-on: https://chromium-review.googlesource.com/601439 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#492561} [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/chrome/browser/resources/chromeos/login/oobe.html [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/chrome/browser/resources/chromeos/login/oobe.js [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/chrome/browser/resources/chromeos/login/oobe_screens.html [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/ui/login/account_picker/md_screen_account_picker.css [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/ui/login/account_picker/md_user_pod_row.css [modify] https://crrev.com/bad25d79920ef48c94769cbccf12d93d6e1a8e46/ui/login/account_picker/user_pod_row.css
,
Aug 8 2017
,
Aug 8 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 8 2017
,
Aug 8 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c877dc9f03da277c2719464bd67e20707ed0cef5 commit c877dc9f03da277c2719464bd67e20707ed0cef5 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Aug 10 18:44:48 2017 Cleans up old account picker use in OOBE Fixes the edge case in OOBE that may show the old UI for public session pods (see bug). It's not necessary to have a forked md_oobe.js because it works with the switch --show-no-md-login (which is used to display the old UI). 'oobe-shield' is replaced with 'login-shield' in oobe.js. TBR=wzang@chromium.org (cherry picked from commit bad25d79920ef48c94769cbccf12d93d6e1a8e46) Bug: 751922 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3ee32fed770efdac74e13e253aafecdafed6126f Reviewed-on: https://chromium-review.googlesource.com/601439 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492561} Reviewed-on: https://chromium-review.googlesource.com/610932 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#447} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/chrome/browser/resources/chromeos/login/oobe.html [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/chrome/browser/resources/chromeos/login/oobe.js [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/chrome/browser/resources/chromeos/login/oobe_screens.html [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/ui/login/account_picker/md_screen_account_picker.css [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/ui/login/account_picker/md_user_pod_row.css [modify] https://crrev.com/c877dc9f03da277c2719464bd67e20707ed0cef5/ui/login/account_picker/user_pod_row.css
,
Aug 15 2017
As verified in M61.0.3163.41:9765.28.0 dev Daisy, public session pod and dialog UI no longer show "password" field. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krishna...@chromium.org
, Aug 3 2017