Purple Bot on tryserver.chromium.perf: Mac Builder |
||||||
Issue descriptionLink to buildbot status page: https://build.chromium.org/p/tryserver.chromium.perf/builders/Mac%20Builder/ This was failing consistently with some bot_update issue, tried clobbering it and now fails with this: Traceback (most recent call last): File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/run.py", line 326, in _new_run recipe_result = recipe_script.run(api, properties) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 98, in run self.run_steps, properties, self.PROPERTIES, api=api) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 627, in invoke_with_properties **additional_args) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 588, in _invoke_with_properties return callable_obj(*props, **additional_args) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/recipes/chromium.py", line 51, in RunSteps api.chromium_tests.main_waterfall_steps() File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 637, in _inner return func(*a, **kw) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 859, in main_waterfall_steps update_step, bot_db = self.prepare_checkout(bot_config) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 637, in _inner return func(*a, **kw) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/recipe_modules/chromium_tests/api.py", line 224, in prepare_checkout bot_config, root_solution_revision, disable_syntax_validation) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 637, in _inner return func(*a, **kw) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/recipe_modules/chromium_checkout/api.py", line 78, in ensure_checkout disable_syntax_validation=disable_syntax_validation) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 637, in _inner return func(*a, **kw) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/api.py", line 112, in ensure_checkout self.m.properties.get('patch_project'), cfg) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 637, in _inner return func(*a, **kw) File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/gclient/api.py", line 334, in calculate_patch_root return cfg.solutions[0].name File "/b/rr/tmpa0oDjB/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/config.py", line 525, in __getitem__ return self.data.__getitem__(index) IndexError: list index out of range
,
Aug 7 2017
Fixing things that never worked is outside of the perview of troopers. Moving this into the recipes component.
,
Aug 7 2017
This is really a chromium tests issue. cc-ing some chromium tests people. I can take a look tomorrow as well. Not sure what the correct component is.
,
Aug 8 2017
Weird. This looks like a bot_update-ism; Ryan, can you take a look?
,
Aug 8 2017
It's failing here because no solution is given, probably because it's gclient config inside the recipe was never set: https://cs.chromium.org/chromium/tools/depot_tools/recipes/recipe_modules/gclient/api.py?q=calculate_patch_root&sq=package:chromium&l=334 There's not much I can say beyond that. Maybe try giving that recipe a gclient config. Also the name of this builder doesn't fall in line with try builder naming conventions. it should be "mac_builder", with lowercase and underscores.
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/701e2caad3d85cfe6917adedde6fe870b9ae4bd3 commit 701e2caad3d85cfe6917adedde6fe870b9ae4bd3 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Aug 16 20:28:27 2017 Switch Mac Builder over to chromium_trybot recipe The Mac Builder builder on the tryserver.chromium.perf waterfall is configured in crrev.com/5119c65f35d76e51433b5d21b8e5f21d2841c044/scripts/slave/recipe_modules/chromium_tests/trybots.py#562 The builder is running the chromium recipe though, so I don't think it's using that file to determine what to run. Using the chromium_trybot recipe should fix the problem. Bug: 751900 Change-Id: I67687fb6000c41cf30010cc2afacc5bb1be68c82 Reviewed-on: https://chromium-review.googlesource.com/611048 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/701e2caad3d85cfe6917adedde6fe870b9ae4bd3/masters/master.tryserver.chromium.perf/master.cfg
,
Aug 16 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/5084156a2fe7735794c41e80f3cf40de3af4d68a commit 5084156a2fe7735794c41e80f3cf40de3af4d68a Author: Stephen Martinis <martiniss@google.com> Date: Wed Aug 16 20:43:08 2017
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/cde23307479318fcb9c8b6bfa7940d422e9cfdc6 commit cde23307479318fcb9c8b6bfa7940d422e9cfdc6 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Aug 16 21:27:47 2017 Actually change pinpoint builder, not regular bisect Correct implementation of what https://chromium-review.googlesource.com/c/611048 was supposed to solve. Bug: 751900 Change-Id: I27da412350c3d95c59c3811c0e5d55634960eb49 Reviewed-on: https://chromium-review.googlesource.com/617655 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/cde23307479318fcb9c8b6bfa7940d422e9cfdc6/masters/master.tryserver.chromium.perf/master.cfg
,
Aug 16 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/8e204afb838343c24f4d9bcbeef1d43e61cda035 commit 8e204afb838343c24f4d9bcbeef1d43e61cda035 Author: Stephen Martinis <martiniss@google.com> Date: Wed Aug 16 21:39:08 2017
,
Aug 16 2017
Nice catch. Don't know if I would've spotted that
,
Aug 17 2017
I ran a build on the new builder and it looks great. Thanks, Stephen! https://build.chromium.org/p/tryserver.chromium.perf/builders/Mac%20Builder/builds/94 The build ran green, synced to the exact revisions I specified (including a DEPS roll and patch), and the correct isolates are in the Pinpoint datastore. from dashboard.pinpoint.models import change from dashboard.pinpoint.models import isolate base_commit = change.Dep('chromium', '4f09cf2507ff61d8c414a0568e10ee7e5a6a39b0') deps = [change.Dep('catapult', '01ea3803d6f50394b0940079c1e4cf4969861e1f')] patch = change.Patch('https://codereview.chromium.org', 2851943002, 40001) c = change.Change(base_commit, deps, patch) assert isolate.Get('Mac Builder', c, 'media_perftests') == 'ff8bdf17d6aa354bb7422c8da7b0ee8ad0cf4480' assert isolate.Get('Mac Builder', c, 'telemetry_perf_tests') == 'ff16ba0a300e758329167f89d348260ae6c4b573' |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtu@chromium.org
, Aug 3 2017