New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751899 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add DNS code to libchrome

Project Member Reported by cernekee@chromium.org, Aug 3 2017

Issue description

arc-networkd is carrying a local copy of these files from net/dns:

big_endian.cc
big_endian.h
dns_protocol.h
dns_response.cc
dns_response.h
io_buffer.cc
io_buffer.h
net_export.h

IsValidDNSDomain() from dns_util.cc would be useful for shill.

Would it be possible to add these files into the next libchrome / libbase uprev?
 
Cc: vapier@chromium.org derat@chromium.org

Comment 2 by derat@chromium.org, Aug 3 2017

Cc: ejcaruso@chromium.org jcivelli@chromium.org
Components: OS>Packages Platform>ARC
Owner: cernekee@chromium.org
jcivelli@ is in the process of doing an uprev, so I'm not sure when the next one will be. I don't think you need an uprev for this, though (assuming r456626 is recent enough); you "just" need to add the files you want from the existing version.

I think you'd need to:

a) Check in the files you want to the AOSP external/libchrome repository.
b) Update SConstruct to build a new libbase-net shared lib with those file.
Cc: hidehiko@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment