New issue
Advanced search Search tips

Issue 751892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Make renderer statistics availble over DT protocol

Project Member Reported by alph@chromium.org, Aug 3 2017

Issue description

Things like JS memory stats, DOM counters, timings (TTI, FMP, FCP) should be made available.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2326c3a7b988ed9cc668dd00e398cc103615d53d

commit 2326c3a7b988ed9cc668dd00e398cc103615d53d
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Aug 10 23:48:54 2017

DevTools: Introduce performance metrics API in the protocol.

The following methods are added to Performance domain:
  - enable
  - disable
  - getMetrics

The metrics are collected per Local Frame root. The patch adds
a single metric for DocumentCount.

Bug:  751892 
Change-Id: I3e45eaf78b4b4b2c3c5fa55d6fc9cc205b1b63a1
Reviewed-on: https://chromium-review.googlesource.com/599350
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493603}
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/content/browser/devtools/protocol/schema_handler.cc
[add] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-counters-expected.txt
[add] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-counters.js
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/LayoutTests/inspector/agents-enable-disable-expected.txt
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/inspector/BUILD.gn
[add] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.cpp
[add] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.h
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/2326c3a7b988ed9cc668dd00e398cc103615d53d/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b84bd19fe587b69d59d07dd8f0164e5b5eff110

commit 7b84bd19fe587b69d59d07dd8f0164e5b5eff110
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Aug 14 21:01:12 2017

DevTools: Make console.timeStamp generate Performance.metrics event

The event is generated when Performance domain is enabled.

BUG= 751892 

Change-Id: I9662229542d4da908d596148e641181184d47114
Reviewed-on: https://chromium-review.googlesource.com/612696
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494186}
[add] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics-expected.txt
[add] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics.js
[modify] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.cpp
[modify] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.h
[modify] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/Source/core/probe/CoreProbes.json5
[modify] https://crrev.com/7b84bd19fe587b69d59d07dd8f0164e5b5eff110/third_party/WebKit/Source/core/probe/CoreProbes.pidl

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b3946dccb285e871373fd4cb7fb7bfa86c7afed

commit 3b3946dccb285e871373fd4cb7fb7bfa86c7afed
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Aug 14 22:10:31 2017

[DevTools] Add instance counters to Performance.getMetrics API

BUG= 751892 

Change-Id: I019c060a78ecaa7dfd91836c28c9a18d3ddc9470
Reviewed-on: https://chromium-review.googlesource.com/612560
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494202}
[delete] https://crrev.com/199d351448e84159f9c3a0fd0da55f0069575088/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-counters-expected.txt
[add] https://crrev.com/3b3946dccb285e871373fd4cb7fb7bfa86c7afed/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics-expected.txt
[rename] https://crrev.com/3b3946dccb285e871373fd4cb7fb7bfa86c7afed/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics.js
[modify] https://crrev.com/3b3946dccb285e871373fd4cb7fb7bfa86c7afed/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/3b3946dccb285e871373fd4cb7fb7bfa86c7afed/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/3b3946dccb285e871373fd4cb7fb7bfa86c7afed/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.cpp
[modify] https://crrev.com/3b3946dccb285e871373fd4cb7fb7bfa86c7afed/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2eccf9ef15cc5450824b51339f9d73633f3992c

commit d2eccf9ef15cc5450824b51339f9d73633f3992c
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Aug 14 23:04:04 2017

DevTools: Followup for r494202

Updating the expectations.

BUG= 751892 
TBR=pfeldman@chromium.org
NOTRY=true

Change-Id: I59fff74297e5858d9f9d9ef8186590339c83d5c6
Reviewed-on: https://chromium-review.googlesource.com/614781
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494227}
[modify] https://crrev.com/d2eccf9ef15cc5450824b51339f9d73633f3992c/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics-expected.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e75d9f200354d1f4366af8fcc64ef1732dd99b9

commit 1e75d9f200354d1f4366af8fcc64ef1732dd99b9
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Aug 16 17:21:56 2017

DevTools: Expose page performance timings over Performance.metrics API

BUG= 751892 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8e85e148a64cdbc922d96627a0367f521b882f02
Reviewed-on: https://chromium-review.googlesource.com/615721
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494841}
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics-expected.txt
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics.js
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics-expected.txt
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-push-metrics.js
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.cpp
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.h
[modify] https://crrev.com/1e75d9f200354d1f4366af8fcc64ef1732dd99b9/third_party/WebKit/Source/core/paint/PaintTiming.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd67d11b1e0af1b43ee477a7e3f12f295d78392

commit dcd67d11b1e0af1b43ee477a7e3f12f295d78392
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Aug 17 00:01:38 2017

DevTools: Support restoring InspectorPerformanceAgent state.

BUG= 751892 

Change-Id: Idc342d4811b067bb96e56233b032ad611e78ee33
Reviewed-on: https://chromium-review.googlesource.com/617306
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495003}
[modify] https://crrev.com/dcd67d11b1e0af1b43ee477a7e3f12f295d78392/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.cpp
[modify] https://crrev.com/dcd67d11b1e0af1b43ee477a7e3f12f295d78392/third_party/WebKit/Source/core/inspector/InspectorPerformanceAgent.h

Comment 10 by alph@chromium.org, Aug 24 2017

Screenshot from 2017-08-24 11:29:48.png
38.4 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb26e22ec02553c149194e9baf29571a4af3d2b

commit ecb26e22ec02553c149194e9baf29571a4af3d2b
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Aug 26 01:17:48 2017

DevTools: Add performance monitor drawer pane.

Initial implementation. It is put behind an experiment.

BUG= 751892 

Change-Id: I3f9a79c7aa2875c2c8a82b32ea42595ea160bde3
Reviewed-on: https://chromium-review.googlesource.com/627668
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497627}
[modify] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/front_end/main/Main.js
[add] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/front_end/sdk/PerformanceMetricsModel.js
[modify] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/front_end/sdk/module.json
[add] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
[modify] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/front_end/timeline/module.json
[add] https://crrev.com/ecb26e22ec02553c149194e9baf29571a4af3d2b/third_party/WebKit/Source/devtools/front_end/timeline/performanceMonitor.css

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ba4c36be588ea9c60c26000c47bc1271de5d70

commit b3ba4c36be588ea9c60c26000c47bc1271de5d70
Author: Alexei Filippov <alph@chromium.org>
Date: Tue Aug 29 00:18:06 2017

DevTools: Introduce control pane for performance monitor.

Drive-by: indicator values are shown with DOM instead of canvas now.

BUG= 751892 

Change-Id: I409b0b7f84adcbcbfb0b3b055247de82a1ffa21f
Reviewed-on: https://chromium-review.googlesource.com/636846
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497953}
[modify] https://crrev.com/b3ba4c36be588ea9c60c26000c47bc1271de5d70/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
[modify] https://crrev.com/b3ba4c36be588ea9c60c26000c47bc1271de5d70/third_party/WebKit/Source/devtools/front_end/timeline/performanceMonitor.css

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 5 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02a4c5cba04f3733e5d04f44666e029d79aa0ce7

commit 02a4c5cba04f3733e5d04f44666e029d79aa0ce7
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Sep 15 02:29:40 2017

DevTools: Make a single toggle per chart in Performance monitor.

BUG= 751892 

Change-Id: I8cee152331c23a645ff4e43af82f77b18b035459
Reviewed-on: https://chromium-review.googlesource.com/644867
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502137}
[modify] https://crrev.com/02a4c5cba04f3733e5d04f44666e029d79aa0ce7/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b372f306d2f05caca997b85ab1622677d810f543

commit b372f306d2f05caca997b85ab1622677d810f543
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Oct 18 20:19:53 2017

DevTools: Implement stacked chart for CPU usage in perf monitor.

BUG= 751892 

Change-Id: Ifdbc908b6bfc3dc1a4a6fa2a2d8e65a8f057b76b
Reviewed-on: https://chromium-review.googlesource.com/724681
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509851}
[modify] https://crrev.com/b372f306d2f05caca997b85ab1622677d810f543/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50819ff38f1645d067dfa442c6664481b9314c24

commit 50819ff38f1645d067dfa442c6664481b9314c24
Author: Alexei Filippov <alph@chromium.org>
Date: Thu Oct 19 21:57:41 2017

DevTools: Add vertical scrollbar to the performance monitor.

BUG= 751892 

Change-Id: I8323075c239ba3a1abc785c4b6b14c6ae9c8e144
Reviewed-on: https://chromium-review.googlesource.com/726966
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510229}
[modify] https://crrev.com/50819ff38f1645d067dfa442c6664481b9314c24/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
[modify] https://crrev.com/50819ff38f1645d067dfa442c6664481b9314c24/third_party/WebKit/Source/devtools/front_end/timeline/performanceMonitor.css

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d39020fac2749a17019032409ad1b0f1d780697

commit 3d39020fac2749a17019032409ad1b0f1d780697
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Oct 20 20:29:50 2017

DevTools: change perfmon circle swatches to check marks.

BUG= 751892 

Change-Id: I7a0782963e58284e8354410f77c264f3fd937ee2
Reviewed-on: https://chromium-review.googlesource.com/727362
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510546}
[modify] https://crrev.com/3d39020fac2749a17019032409ad1b0f1d780697/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
[modify] https://crrev.com/3d39020fac2749a17019032409ad1b0f1d780697/third_party/WebKit/Source/devtools/front_end/timeline/performanceMonitor.css

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/add26946cf441cb416dfbe8a02d5d91755809222

commit add26946cf441cb416dfbe8a02d5d91755809222
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Oct 20 20:53:16 2017

DevTools: Suspend perfmon on performance profiling.

BUG= 751892 

Change-Id: Ide99f302ec8fb785c9b147ee4fc45e470ca83974
Reviewed-on: https://chromium-review.googlesource.com/729491
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510555}
[modify] https://crrev.com/add26946cf441cb416dfbe8a02d5d91755809222/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js
[modify] https://crrev.com/add26946cf441cb416dfbe8a02d5d91755809222/third_party/WebKit/Source/devtools/front_end/timeline/performanceMonitor.css

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a51563bd22a3c1c015f48ad50e2e77c28516063

commit 9a51563bd22a3c1c015f48ad50e2e77c28516063
Author: Alexei Filippov <alph@chromium.org>
Date: Sat Oct 21 14:33:18 2017

DevTools: Instantly rescale Perfmon chart on start up.

BUG= 751892 

Change-Id: Ic63f8d043e050981910eb4fc10014d4d26ff0e13
Reviewed-on: https://chromium-review.googlesource.com/729043
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510681}
[modify] https://crrev.com/9a51563bd22a3c1c015f48ad50e2e77c28516063/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceMonitor.js

Comment 21 by alph@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)

Comment 22 by alph@chromium.org, Nov 15 2017

Labels: -Type-Bug Type-Feature

Sign in to add a comment