New issue
Advanced search Search tips

Issue 751880 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Assertion thrown in import while extracting owners

Project Member Reported by qyears...@chromium.org, Aug 2 2017

Issue description

Log excerpt:

Traceback (most recent call last):
  File ".../wpt-import", line 18, in <module>
    host.exit(importer.main())
  File ".../webkitpy/w3c/test_importer.py", line 122, in main
    self._upload_cl()
  File ".../webkitpy/w3c/test_importer.py", line 385, in _upload_cl
    directory_owners = self.get_directory_owners()
  File ".../webkitpy/w3c/test_importer.py", line 409, in get_directory_owners
    return extractor.list_owners(changed_files)
  File ".../webkitpy/w3c/directory_owners_extractor.py", line 42, in list_owners
    owners_file, owners = self.find_and_extract_owners(self.filesystem.dirname(relpath))
  File ".../webkitpy/w3c/directory_owners_extractor.py", line 69, in find_and_extract_owners
    assert directory.startswith(external_root)
AssertionError

Example log: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F413%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout


Robert, this is probably just a minor thing, I'll look into it tomorrow if you don't fix it first :-)
 
Status: Fixed (was: Available)
Fixed by Raphael.

CL: https://chromium-review.googlesource.com/c/599908
which was linked with the original bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=713987&desc=2#c19

I had a comment at the very end of the above bug, if you could take a look and confirm.

Sign in to add a comment