New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: replace the deprecated neon-animation elements.

Project Member Reported by scottchen@chromium.org, Aug 2 2017

Issue description

replace it with our simplified version of view-managing element.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52d7ff244f41063ccbbb9e8adf73186bbf457d87

commit 52d7ff244f41063ccbbb9e8adf73186bbf457d87
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Aug 09 06:07:22 2017

MD Extensions: add ViewManager to handle view transitions.

The transition between views (or "pages") is currently done in 
neon-animated-pages, but neon-animated-pages is now deprecated, and also comes
with a lot of other utilities that we don't use. This CL creates a ViewManager
that replaces neon-animated-pages in handling transition animations.

Only fade-in/out animation will be supported right away (UX approved). But
adding other animations will be easy by adding to the viewAnimations map.

Bug:  751865 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7edd37c441ad9d7de86458a48397a6f8699c7b0c
Reviewed-on: https://chromium-review.googlesource.com/600835
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492847}
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/browser_resources.grd
[delete] https://crrev.com/7a6f47e3a5e77e77fcd6334285dcb942db0916d2/chrome/browser/resources/md_extensions/animation_helper.html
[delete] https://crrev.com/7a6f47e3a5e77e77fcd6334285dcb942db0916d2/chrome/browser/resources/md_extensions/animation_helper.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/error_page.html
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/error_page.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/item_list.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/keyboard_shortcuts.html
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/keyboard_shortcuts.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/toolbar.html
[add] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/view_manager.html
[add] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/resources/md_extensions/view_manager.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/test/data/webui/extensions/extension_manager_test.js
[add] https://crrev.com/52d7ff244f41063ccbbb9e8adf73186bbf457d87/chrome/test/data/webui/extensions/extension_view_manager_test.js

Status: Fixed (was: Started)

Sign in to add a comment