New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751853 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

Several services_unittests failing on android and linux under asan

Project Member Reported by thakis@chromium.org, Aug 2 2017

Issue description

https://luci-milo.appspot.com/buildbot/chromium.fyi/ClangToTLinuxASan%20tester/2187

ChromeTraceEventAgentTest.StopAndFlushEvents
ChromeTraceEventAgentTest.StopAndFlushMetadata
ChromeTraceEventAgentTest.StartTracing
MockVideoCaptureDeviceTest.DeviceIsStoppedWhenDiscardingDeviceProxy
MockVideoCaptureDeviceTest.DeviceIsStoppedWhenDiscardingDeviceClient

Two types of stack:

Direct leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x591018 in operator new(unsigned long) /b/c/builder/ClangToTLinuxASan/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92
    #1 0x34fff64 in MakeUnique<video_capture::ReceiverMojoToMediaAdapter, mojo::InterfacePtr<video_capture::mojom::Receiver> > base/memory/ptr_util.h:56:29
    #2 0x34fff64 in video_capture::DeviceMediaToMojoAdapter::Start(media::VideoCaptureParams const&, mojo::InterfacePtr<video_capture::mojom::Receiver>) services/video_capture/device_media_to_mojo_adapter.cc:52
    #3 0x3528103 in video_capture::mojom::DeviceStubDispatch::Accept(video_capture::mojom::Device*, mojo::Message*) /b/c/builder/ClangToTLinuxASan/src/out/Release/gen/services/video_capture/public/interfaces/device.mojom.cc:646:13
    #4 0x375c1dc in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:420:32
    #5 0x37704ff in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::Message*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) mojo/public/cpp/bindings/lib/multiplex_router.cc:886:22
    #6 0x376f6f8 in mojo::internal::MultiplexRouter::Accept(mojo::Message*) mojo/public/cpp/bindings/lib/multiplex_router.cc:613:25
    #7 0x3759985 in mojo::Connector::ReadSingleMessage(unsigned int*) mojo/public/cpp/bindings/lib/connector.cc:440:51
    #8 0x375b21c in mojo::Connector::ReadAllAvailableMessages() mojo/public/cpp/bindings/lib/connector.cc:469:10
    #9 0x34d880a in Run base/callback.h:80:12
    #10 0x34d880a in mojo::SimpleWatcher::DiscardReadyState(base::Callback<void (unsigned int), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned int, mojo::HandleSignalsState const&) mojo/public/cpp/system/simple_watcher.h:193
    #11 0x3798c59 in Run base/callback.h:80:12
    #12 0x3798c59 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) mojo/public/cpp/system/simple_watcher.cc:276
    #13 0x35561f6 in Run base/callback.h:91:12
    #14 0x35561f6 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59
    #15 0x359a511 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:404:19
    #16 0x359b620 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:415:5
    #17 0x359c38d in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:522:13
    #18 0x35a2a18 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
    #19 0x35de267 in base::RunLoop::Run() base/run_loop.cc:112:14
    #20 0xba7268 in video_capture::MockVideoCaptureDeviceTest_DeviceIsStoppedWhenDiscardingDeviceProxy_Test::TestBody() services/video_capture/test/mock_device_unittest.cc:28:13
    #21 0xdff5dc in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #22 0xdff5dc in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2471
    #23 0xe01284 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #24 0xe02636 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #25 0xe17e46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #26 0xe173b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #27 0xe173b7 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4256
    #28 0x534cb61 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46



Direct leak of 56 byte(s) in 1 object(s) allocated from:
    #0 0x591018 in operator new(unsigned long) /b/c/builder/ClangToTLinuxASan/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92
    #1 0x53553ed in trace_analyzer::TraceAnalyzer::Create(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) base/test/trace_event_analyzer.cc:738:43
    #2 0x803672 in tracing::MockRecorder::AddChunk(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent_unittest.cc:50:22
    #3 0x2f47f2e in tracing::mojom::RecorderStubDispatch::Accept(tracing::mojom::Recorder*, mojo::Message*) /b/c/builder/ClangToTLinuxASan/src/out/Release/gen/services/resource_coordinator/public/interfaces/tracing/tracing.mojom.cc:1250:13
    #4 0x375c1dc in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:420:32
    #5 0x37704ff in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::Message*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) mojo/public/cpp/bindings/lib/multiplex_router.cc:886:22
    #6 0x376f6f8 in mojo::internal::MultiplexRouter::Accept(mojo::Message*) mojo/public/cpp/bindings/lib/multiplex_router.cc:613:25
    #7 0x3759985 in mojo::Connector::ReadSingleMessage(unsigned int*) mojo/public/cpp/bindings/lib/connector.cc:440:51
    #8 0x375b21c in mojo::Connector::ReadAllAvailableMessages() mojo/public/cpp/bindings/lib/connector.cc:469:10
    #9 0x34d880a in Run base/callback.h:80:12
    #10 0x34d880a in mojo::SimpleWatcher::DiscardReadyState(base::Callback<void (unsigned int), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned int, mojo::HandleSignalsState const&) mojo/public/cpp/system/simple_watcher.h:193
    #11 0x3798c59 in Run base/callback.h:80:12
    #12 0x3798c59 in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) mojo/public/cpp/system/simple_watcher.cc:276
    #13 0x35561f6 in Run base/callback.h:91:12
    #14 0x35561f6 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59
    #15 0x359a511 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:404:19
    #16 0x359b620 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:415:5
    #17 0x359c38d in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:522:13
    #18 0x35a2a18 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:33:31
    #19 0x35de267 in base::RunLoop::Run() base/run_loop.cc:112:14
    #20 0x7ff264 in tracing::ChromeTraceEventAgentTest_StopAndFlushEvents_Test::TestBody() services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent_unittest.cc:148:12
    #21 0xdff5dc in HandleExceptionsInMethodIfSupported<testing::Test, void> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #22 0xdff5dc in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2471
    #23 0xe01284 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2653:11
    #24 0xe02636 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2771:28
    #25 0xe17e46 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4648:43
    #26 0xe173b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/src/googletest/src/gtest.cc:2455:12
    #27 0xe173b7 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:4256
    #28 0x534cb61 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46



services_unittests probably doesn't run on the public asan bots yet. It should.
 
ping?
Summary: Several services_unittests failing on android and linux under asan (was: Several services_unittests failing on android under asan)
Also on linux: https://reviews.llvm.org/D35192

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad928ca5744c95d4495965ea96cb851468e23f9e

commit ad928ca5744c95d4495965ea96cb851468e23f9e
Author: Elliot Glaysher <erg@chromium.org>
Date: Thu Aug 03 17:51:21 2017

Fix remaining memory errors in services_unittests.

Also enables services_unittests on the linux asan bots.

Bug:  751853 
Change-Id: Ia4ea33100405c657fd0ee40fe15306e997193ce8
Reviewed-on: https://chromium-review.googlesource.com/599038
Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491785}
[modify] https://crrev.com/ad928ca5744c95d4495965ea96cb851468e23f9e/services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent_unittest.cc
[modify] https://crrev.com/ad928ca5744c95d4495965ea96cb851468e23f9e/services/video_capture/test/mock_device_unittest.cc
[modify] https://crrev.com/ad928ca5744c95d4495965ea96cb851468e23f9e/testing/buildbot/chromium.memory.json

Comment 4 by e...@chromium.org, Aug 3 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment