New issue
Advanced search Search tips

Issue 751844 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 800570
Owner: ----
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Baselines for wpt tests with query strings are merged

Project Member Reported by qyears...@chromium.org, Aug 2 2017

Issue description

For example:

For several files in https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/, there are multiple tests with different query strings, for example:

  .../html5lib_template.html?run_type=write_single
  .../html5lib_template.html?run_type=write
  .../html5lib_template.html?run_type=uri

Based on the logic at https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py#150, we're expecting that there should be separate baselines for separate tests, e.g.:

  .../html5lib_template.html_run_type=write_single-expected.txt
  .../html5lib_template.html_run_type=write-expected.txt
  .../html5lib_template.html_run_type=uri-expected.txt

But instead there is only one file:

  .../html5lib_template-expected.txt

One possible relevant area of code that probably needs to be changed:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py#534

When this is fixed, the importer code that cleans up orphaned baselines will also have to be updated:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py#324
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 800570
Status: Duplicate (was: Untriaged)
Oh I've fixed this :)

Sign in to add a comment