New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751839 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 753243



Sign in to add a comment

Implement animations for Peeking to Fullscreen transition.

Project Member Reported by newcomer@chromium.org, Aug 2 2017

Issue description

Blocked on Spec.

Implement the new transition for Peeking to Fullscreen. (the internals of the launcher, not the body.)

 
Owner: mccanny@chromium.org
Assigning this to Ben as his prototype should be clear enough to handle this.
Please check with him directly for guidance.
mccanny@, Any updates here?


Labels: M-61 Merge-Request-61
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OSs. Thank you.
Labels: OS-Chrome
Owner: newcomer@chromium.org
Apologies for the delay. I spoke to Alex offline but I think Min may already be working on this. Here's a link to the spec documents just in case:

https://drive.google.com/open?id=0B857c6KwBR6oeXVlZ0wtYXpNM2c

Let me know if you have any questions.
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 14 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by minch@chromium.org, Aug 16 2017

Owner: minch@chromium.org
Taking this one, since the same reason to this issue https://bugs.chromium.org/p/chromium/issues/detail?id=754065
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 17 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 753243
Status: Assigned (was: Available)

Comment 14 by minch@chromium.org, Aug 18 2017

Status: Started (was: Assigned)
peekng-fullscreen.webm
8.7 MB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e

commit 7f9ce57a9c9462cc30eead33d7ad4858ed0d692e
Author: MinChen <minch@chromium.org>
Date: Wed Aug 23 18:56:34 2017

Combine STATE_START and STATE_APPS pages to AppsContainerView.

changes:
1. Add AppsContainerView as STATE_START corresponding page for fullscreen
app list. Don't add start page view if it is not fullscreen app list.
2. Make AppsContainerView process the bounds for STATE_START state.
3. Add GetSearchBoxBoundsForState(AppListModel::State) to AppListPage.
4. Add expand arrow in AppsGridView.

Specs:
https://drive.google.com/corp/drive/folders/0B857c6KwBR6oeXVlZ0wtYXpNM2c

Video recored: Please take a look at
https://bugs.chromium.org/p/chromium/issues/detail?id=751839

Bug:  751839 ,754065
Change-Id: Ida62833d8aad7e9dd21477506696987c8563f80a
Reviewed-on: https://chromium-review.googlesource.com/619391
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496757}
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/app_list_constants.h
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/app_list_page.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/app_list_page.h
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/apps_container_view.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/7f9ce57a9c9462cc30eead33d7ad4858ed0d692e/ui/app_list/views/start_page_view.h

Comment 16 by minch@chromium.org, Aug 23 2017

Status: Fixed (was: Started)
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 29 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb

commit 8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb
Author: Maajid <maajid@chromium.org>
Date: Tue Aug 29 19:44:35 2017

Combine STATE_START and STATE_APPS pages to AppsContainerView.

changes:
1. Add AppsContainerView as STATE_START corresponding page for fullscreen
app list. Don't add start page view if it is not fullscreen app list.
2. Make AppsContainerView process the bounds for STATE_START state.
3. Add GetSearchBoxBoundsForState(AppListModel::State) to AppListPage.
4. Add expand arrow in AppsGridView.

Specs:
https://drive.google.com/corp/drive/folders/0B857c6KwBR6oeXVlZ0wtYXpNM2c

Video recored: Please take a look at
https://bugs.chromium.org/p/chromium/issues/detail?id=751839

TBR=minch@chromium.org

(cherry picked from commit 7f9ce57a9c9462cc30eead33d7ad4858ed0d692e)

Bug:  751839 ,754065
Change-Id: Ida62833d8aad7e9dd21477506696987c8563f80a
Reviewed-on: https://chromium-review.googlesource.com/619391
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496757}
Reviewed-on: https://chromium-review.googlesource.com/641314
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#979}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/app_list_constants.h
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/app_list_page.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/app_list_page.h
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/apps_container_view.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/apps_container_view.h
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/search_box_view.h
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/8dfa06af149d0fe21d7dabce0cef67c79dc4e0fb/ui/app_list/views/start_page_view.h

Comment 18 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment