New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751834 link

Starred by 1 user
Status: Archived
Owner:
newcomer@chromium.org
Closed: Aug 2017
Cc:
█ maajid@chromium.org
█ vadimt@chromium.org
weidongg@chromium.org
█ warx@chromium.org
Components:
EstimatedDays: 1
NextAction: ----
OS: Chrome
Pri: 1
Type: Task



Sign in to add a comment

Disable webstore search when playstore search is active.

Project Member Reported by newcomer@chromium.org, Aug 2 2017 
When playstore search is active, do not use webstore search.

webstore apps have been deprecated:
https://blog.chromium.org/2016/08/from-chrome-apps-to-web.html
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/782e893698632692daf1730a13e7d843acc8f330

commit 782e893698632692daf1730a13e7d843acc8f330
Author: Alex Newcomer <newcomer@chromium.org>
Date: Wed Aug 02 22:41:11 2017

cros: Disable webstore search in favor of playstore

When playstore search is enabled, disable webstore search.

Bug:  751834 
Change-Id: Ibcdcf7b90ae1c96debdc66854dfbc71f80c21421
Reviewed-on: https://chromium-review.googlesource.com/599067
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491534}
[modify] https://crrev.com/782e893698632692daf1730a13e7d843acc8f330/chrome/browser/ui/app_list/search/search_controller_factory.cc

Comment 2 by newcomer@chromium.org, Aug 2 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6c4cf43bed753abe5be0adc9dfd76892efddfe

commit ef6c4cf43bed753abe5be0adc9dfd76892efddfe
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Aug 04 17:46:52 2017

cros: Disable webstore search in favor of playstore

When playstore search is enabled, disable webstore search.

TBR=newcomer@chromium.org

(cherry picked from commit 782e893698632692daf1730a13e7d843acc8f330)

Bug:  751834 
Change-Id: Ibcdcf7b90ae1c96debdc66854dfbc71f80c21421
Reviewed-on: https://chromium-review.googlesource.com/599067
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491534}
Reviewed-on: https://chromium-review.googlesource.com/602449
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#319}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/ef6c4cf43bed753abe5be0adc9dfd76892efddfe/chrome/browser/ui/app_list/search/search_controller_factory.cc

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment