New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751821 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

AnimationPlayerTest.ToString flake

Project Member Reported by vmp...@chromium.org, Aug 2 2017

Issue description

I get 100% repro on the failure running this:

./out/Debug/cc_unittests --single-process-tests --gtest_filter="AnimationPlayerTest.ToString:LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster"

Here's the output:
[==========] Running 2 tests from 2 test cases.
[----------] Global test environment set-up.
[----------] 1 test from LayerTreeHostTilesTestPartialInvalidation
[ RUN      ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster
[       OK ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster (533 ms)
[----------] 1 test from LayerTreeHostTilesTestPartialInvalidation (533 ms total)

[----------] 1 test from AnimationPlayerTest
[ RUN      ] AnimationPlayerTest.ToString
../../cc/animation/animation_player_unittest.cc:416: Failure
      Expected: "AnimationPlayer{id=2, element_id=(1), animations=[]}"
To be equal to: player_->ToString()
      Which is: "AnimationPlayer{id=3, element_id=(1), animations=[]}"
../../cc/animation/animation_player_unittest.cc:425: Failure
      Expected: "AnimationPlayer{id=2, element_id=(1), animations=[Animation{id=42, " "group=73, target_property_id=1, " "run_state=WAITING_FOR_TARGET_AVAILABILITY}]}"
      Which is: "AnimationPlayer{id=2, element_id=(1), animations=[Animation{id=42, group=73, target_property_id=1, run_state=WAITING_FOR_TARGET_AVAILABILITY}]}"
To be equal to: player_->ToString()
      Which is: "AnimationPlayer{id=3, element_id=(1), animations=[Animation{id=42, group=73, target_property_id=1, run_state=WAITING_FOR_TARGET_AVAILABILITY}]}"
../../cc/animation/animation_player_unittest.cc:435: Failure
      Expected: "AnimationPlayer{id=2, element_id=(1), animations=[Animation{id=42, " "group=73, target_property_id=1, " "run_state=WAITING_FOR_TARGET_AVAILABILITY}, Animation{id=45, group=76, " "target_property_id=5, run_state=WAITING_FOR_TARGET_AVAILABILITY}]}"
      Which is: "AnimationPlayer{id=2, element_id=(1), animations=[Animation{id=42, group=73, target_property_id=1, run_state=WAITING_FOR_TARGET_AVAILABILITY}, Animation{id=45, group=76, target_property_id=5, run_state=WAITING_FOR_TARGET_AVAILABILITY}]}"
To be equal to: player_->ToString()
      Which is: "AnimationPlayer{id=3, element_id=(1), animations=[Animation{id=42, group=73, target_property_id=1, run_state=WAITING_FOR_TARGET_AVAILABILITY}, Animation{id=45, group=76, target_property_id=5, run_state=WAITING_FOR_TARGET_AVAILABILITY}]}"
[  FAILED  ] AnimationPlayerTest.ToString (1 ms)
[----------] 1 test from AnimationPlayerTest (1 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 2 test cases ran. (534 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] AnimationPlayerTest.ToString

The test however passes if run on its own. The other test is likely changing the id, so we can't really depend on a hard coded id.

 
Status: Started (was: Assigned)
:(
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1169d259b3bf1064514bc244207eaa13c42f58e

commit f1169d259b3bf1064514bc244207eaa13c42f58e
Author: Walter Korman <wkorman@chromium.org>
Date: Fri Aug 04 17:04:25 2017

Fix flaky AnimationPlayer ToString test.

Don't hard code player and element id. We could alternatively set
specific player and element ids, but we may as well rely on those
created for us by the base test class.

Bug:  751821 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib95acd9f349d9b6fda4f8b2e9de9d5759a3070fe
Reviewed-on: https://chromium-review.googlesource.com/600887
Commit-Queue: Walter Korman <wkorman@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492054}
[modify] https://crrev.com/f1169d259b3bf1064514bc244207eaa13c42f58e/cc/animation/animation_player_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment