New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751818 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 717738



Sign in to add a comment

Failure to upload perf data because of invalid seconds_since_epoch

Project Member Reported by yzshen@chromium.org, Aug 2 2017

Issue description

The new Mojo Perf FYI bot currently cannot upload data:
https://build.chromium.org/p/chromium.perf.fyi/builders/Mojo%20Linux%20Perf/builds/2094


The log shows:

test_results_uploader.PermanentError: Received HTTP status 400 loading "https://test-results.appspot.com/testfile/upload": Invalid value for seconds_since_epoch

That sounds like the time setting is incorrect on the bot.

Sergiy: I heard that you have addressed similar problems. Would you please help or advise what to do with it? Thanks!
 
Cc: aga...@chromium.org
Cc: nedngu...@google.com ashleymarie@chromium.org
Which value are you uploading? I've seen some bpts uploading value in
microseconds instead of seconds, which broke many scripts down the line due
to timestamp being larger than 9999-31-12 23:59:59.999999, which is not
supported by BigQuery. We've now restricted the value to be between 0 and
+1 day from the time on the server, see
https://chromium-review.googlesource.com/c/582009. If you need to upload
different timestamps for some reason, please let me know.
Cc: benjhayden@chromium.org eakuefner@chromium.org
Owner: ashleymarie@chromium.org
Status: Assigned (was: Untriaged)
This seems to be a bug in Telemetry code that constructs time: https://github.com/catapult-project/catapult/blob/f80b3a5f20bec44846b3eee573e4a7f5d96372fd/telemetry/telemetry/internal/results/results_options.py#L203

Also cc'ed Ethan & Ben since benchmark_start_ms is also used in results2 UI.
Cc: -serg...@chromium.org
Thanks. Please re-CC me if needed.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb34528a8b674bea3e27dd45496e7d2201a0ba05

commit eb34528a8b674bea3e27dd45496e7d2201a0ba05
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Aug 04 03:12:12 2017

Roll src/third_party/catapult/ a62e07f86..357e1deef (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a62e07f86606..357e1deefca7

$ git log a62e07f86..357e1deef --date=short --no-merges --format='%ad %ae %s'
2017-08-03 xunjieli [wpr-go] Use a dummy cert if no cert is recorded
2017-08-03 ashleymarie Correct seconds_since_epoch to actually be seconds instead of milliseconds

Created with:
  roll-dep src/third_party/catapult
BUG= 751818 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ie29b6143749e1b0603b86ac9fbe43f86085b25c7
Reviewed-on: https://chromium-review.googlesource.com/601537
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491925}
[modify] https://crrev.com/eb34528a8b674bea3e27dd45496e7d2201a0ba05/DEPS

Status: Fixed (was: Assigned)
This is passing again after that change so it should be fixed
Please reopen if you see it again
Cc: phajdan.jr@chromium.org
 Issue 753009  has been merged into this issue.

Comment 9 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment