Don't speculatively start search service workers if search suggestions are disabled |
||||||||
Issue descriptionCurrently, to disable speculative startup, the user must disable search suggestions* and Javascript, which isn't practical. We should add an explicit check for the former setting in the omnibox code where we decide whether to send the speculative startup signal so that users can more easily disable this functionality if they desire. * The "Use a prediction service to help complete searches and URLs typed in the address bar" setting at chrome://settings/privacy.
,
Aug 2 2017
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5885b868cfb89e8e8841cff59448e1926d7338f commit d5885b868cfb89e8e8841cff59448e1926d7338f Author: Justin Donnelly <jdonnelly@chromium.org> Date: Thu Aug 03 15:18:22 2017 Don't send the service worker startup hint if suggestions are disabled. This is controlled by the "Use a prediction service to help complete searches and URLs typed in the address bar" setting at chrome://settings/privacy. Bug: 751813 Change-Id: Iedf25fbb95e4fe1133fa994843068b26b749e36b Reviewed-on: https://chromium-review.googlesource.com/598933 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#491740} [modify] https://crrev.com/d5885b868cfb89e8e8841cff59448e1926d7338f/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
,
Aug 3 2017
,
Aug 3 2017
Pls apply appropriate OSs. Thank you.
,
Aug 4 2017
,
Aug 4 2017
Approving merge to M61 Chrome OS.
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d0a9e5d1b645a49a0f2537e1e32b30f03a832b7 commit 1d0a9e5d1b645a49a0f2537e1e32b30f03a832b7 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri Aug 04 20:40:29 2017 Don't send the service worker startup hint if suggestions are disabled. This is controlled by the "Use a prediction service to help complete searches and URLs typed in the address bar" setting at chrome://settings/privacy. TBR=jdonnelly@chromium.org (cherry picked from commit d5885b868cfb89e8e8841cff59448e1926d7338f) Bug: 751813 Change-Id: Iedf25fbb95e4fe1133fa994843068b26b749e36b Reviewed-on: https://chromium-review.googlesource.com/598933 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491740} Reviewed-on: https://chromium-review.googlesource.com/602675 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#323} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/1d0a9e5d1b645a49a0f2537e1e32b30f03a832b7/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc1f06772af27fab08b74064b914cbdc5fc7418 commit fbc1f06772af27fab08b74064b914cbdc5fc7418 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri Aug 04 23:31:18 2017 Test disabling service worker startup when suggest is disabled. Actually disabling startup is done in http://crrev.com/c/598933 which is kept simple for merging to M61. This CL moves the test to a better location and tests the behavior. Bug: 751813 Change-Id: Ic8b57af1586599fe73fe642eba759c3c1d678287 Reviewed-on: https://chromium-review.googlesource.com/599011 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#492173} [modify] https://crrev.com/fbc1f06772af27fab08b74064b914cbdc5fc7418/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc [modify] https://crrev.com/fbc1f06772af27fab08b74064b914cbdc5fc7418/chrome/browser/autocomplete/chrome_autocomplete_provider_client_unittest.cc
,
Aug 7 2017
,
Aug 9 2017
@jdonnelly: Could you please provide us the sample repro steps to check the issue from our end? Thanks!!
,
Aug 9 2017
There's nothing that can be verified by manual testing, so no need to try to repro. Thanks for checking, though. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdonnelly@chromium.org
, Aug 2 2017