New issue
Advanced search Search tips

Issue 751812 link

Starred by 2 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Nov 2017
Cc:
thestig@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature

Blocked on:
issue 752660
issue 753007
issue 758654
issue 785170
issue 788679


Sign in to add a comment

Add debian stretch sysroot

Project Member Reported by thomasanderson@chromium.org, Aug 2 2017 
Now that debian stretch is in stable, it's time to consider adding a sysroot for it to eventually switch from the current jessie sysroot.

Comment 1 by thomasanderson@chromium.org, Aug 2 2017

Labels: OS-Linux
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/651ac81c816861f48eab99f8730862bd027ae790

commit 651ac81c816861f48eab99f8730862bd027ae790
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 02 21:28:07 2017

Fix some bugs in sysroot-creator.sh in preparation for adding stretch sysroot

This CL fixes:
* Parsing the release file to obtain the desired SHA256 sum when there
  are multiple hash algorithms listed in different orders.
* Removes a list of directories to relativize symlinks and replaces it
  with a direct check on the directory nesting.

BUG= 751812 
R=thestig@chromium.org

Change-Id: If3692f0633ba7ad059ab3c7d0945f4b7ef11786e
Reviewed-on: https://chromium-review.googlesource.com/598931
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491506}
[modify] https://crrev.com/651ac81c816861f48eab99f8730862bd027ae790/build/linux/sysroot_scripts/sysroot-creator.sh
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/081ae0f5c1a70c28df835123ea7110b7600192bc

commit 081ae0f5c1a70c28df835123ea7110b7600192bc
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Aug 04 17:52:09 2017

Implement readdir()

This CL is needed because Chromium code is switching from readdir_r()
to readdir().  It is a dependency CL of:
https://chromium-review.googlesource.com/c/599120

BUG= chromium:457759 , chromium:751812 
R=bradnelson@chromium.org

Change-Id: Id09ce31b1837d0dc3d4057397d50db2781cabd4d
Reviewed-on: https://chromium-review.googlesource.com/600516
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>

[modify] https://crrev.com/081ae0f5c1a70c28df835123ea7110b7600192bc/src/nonsfi/linux/directory.c
[modify] https://crrev.com/081ae0f5c1a70c28df835123ea7110b7600192bc/tests/nonsfi/directory_test.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26ca1ff809456dfa08bafe3a310c2f3da242d26d

commit 26ca1ff809456dfa08bafe3a310c2f3da242d26d
Author: nacl-deps-roller@chromium.org <nacl-deps-roller@chromium.org>
Date: Fri Aug 04 20:24:40 2017

Roll src/native_client/ 01a28a606..081ae0f5c (1 commit)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/01a28a6069a9..081ae0f5c1a7

$ git log 01a28a606..081ae0f5c --date=short --no-merges --format='%ad %ae %s'
2017-08-03 thomasanderson Implement readdir()

Created with:
  roll-dep src/native_client
BUG= 457759 , 751812 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Change-Id: Iabf19085894aa964e0c93892ba2e2656bfa3ce33
Reviewed-on: https://chromium-review.googlesource.com/602499
Reviewed-by: <nacl-deps-roller@chromium.org>
Commit-Queue: <nacl-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492114}
[modify] https://crrev.com/26ca1ff809456dfa08bafe3a310c2f3da242d26d/DEPS

Comment 7 by thomasanderson@chromium.org, Aug 4 2017

Blockedon: 752660
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e33415240d57999459a2b9376831fa1303eabac

commit 4e33415240d57999459a2b9376831fa1303eabac
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Aug 05 00:06:59 2017

Remove usage of readdir_r() in Chromium code

readdir_r() is deprecated, which causes build failures when using
glibc-2.24 or newer headers.  This CL replaces usage of readdir_r()
with readdir(), and suppresses the warning for third_party code.

BUG= 457759 , 751812 
TBR=brettw@chromium.org

Change-Id: Idfeff0d535926bc53634a7574f00605c50d532ab
Reviewed-on: https://chromium-review.googlesource.com/599120
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Julien Tinnes <jln@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492190}
[modify] https://crrev.com/4e33415240d57999459a2b9376831fa1303eabac/headless/public/util/fontconfig.cc
[modify] https://crrev.com/4e33415240d57999459a2b9376831fa1303eabac/sandbox/linux/services/proc_util.cc
[modify] https://crrev.com/4e33415240d57999459a2b9376831fa1303eabac/third_party/leveldatabase/env_chromium.cc
[modify] https://crrev.com/4e33415240d57999459a2b9376831fa1303eabac/third_party/libdrm/BUILD.gn

Comment 9 by thomasanderson@chromium.org, Aug 7 2017

Blockedon: 753007
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408a3b753ceec15942c080ac9b340b05132e0471

commit 408a3b753ceec15942c080ac9b340b05132e0471
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Aug 07 21:22:57 2017

Fix errno typo in env_chromium.cc

CL [1] removed usage of readdir_r(), but in doing so added a bug where
errno should have been saved_errno.

[1] https://chromium-review.googlesource.com/c/599120

BUG= 751812 
R=jsbell@chromium.org

Change-Id: I5bdc554e62052d050be076bea3eddee9a6850212
Reviewed-on: https://chromium-review.googlesource.com/602697
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492413}
[modify] https://crrev.com/408a3b753ceec15942c080ac9b340b05132e0471/third_party/leveldatabase/env_chromium.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c2ef4092040a7a1fce76b6c543d26de4f2f0f29

commit 4c2ef4092040a7a1fce76b6c543d26de4f2f0f29
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Aug 14 20:07:40 2017

Tcmalloc: Don't use MADV_FREE on linux

MADV_FREE is only available on Linux kernels >= 4.5.  Doing a
compile-time check to see if MADV_FREE is defined is insufficient.
This CL is an upstream of tcmalloc patch [1] which unconditionally
disables usage of MADV_FREE on Linux.  In the future, it would be
better to perform a runtime check so we can still use the feature when
it is available.

[1] https://github.com/gperftools/gperftools/commit/6f7a14f45e2e2e16fbbd250543f5758078e2f5f0

BUG= 751812 
R=wfh@chromium.org

Change-Id: Id1eceecd78ce26f74e8f061906902f7f3c2d650c
Reviewed-on: https://chromium-review.googlesource.com/614104
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494155}
[modify] https://crrev.com/4c2ef4092040a7a1fce76b6c543d26de4f2f0f29/third_party/tcmalloc/chromium/src/system-alloc.cc

Comment 12 by thomasanderson@chromium.org, Aug 24 2017

Blockedon: 758654
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99b48b47f11fabf55f338a049ec8d0473f00e6e7

commit 99b48b47f11fabf55f338a049ec8d0473f00e6e7
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Nov 11 04:07:14 2017

Roll sysroots to include dbus changes

BUG= 751812 
R=thestig@chromium.org

Change-Id: I59ab62bf5fe65dec0f7d7ab2a3aea4219ddcba1a
Reviewed-on: https://chromium-review.googlesource.com/764521
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515820}
[modify] https://crrev.com/99b48b47f11fabf55f338a049ec8d0473f00e6e7/build/linux/sysroot_scripts/sysroots.json
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed08ea9dbb0ce745e974f8a541259a4e8a6a82a

commit 1ed08ea9dbb0ce745e974f8a541259a4e8a6a82a
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Nov 11 04:13:36 2017

Remove duplicated code in sysroot-creator.sh

BUG= 751812 
R=thestig@chromium.org

Change-Id: I3c84383bc4aa01e9cbe288da5c2f2080bfa38057
Reviewed-on: https://chromium-review.googlesource.com/764596
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515822}
[modify] https://crrev.com/1ed08ea9dbb0ce745e974f8a541259a4e8a6a82a/build/linux/sysroot_scripts/sysroot-creator.sh
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f5f9df69889a313470a8530a8a724cf17cca90

commit 97f5f9df69889a313470a8530a8a724cf17cca90
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Nov 13 23:21:55 2017

Switch to Debian Stretch sysroot

This CL switches the default sysroot from Jessie to Stretch.
There are no deps changes.  The libstdc++ requirement is not
affected because we do an in-tree build of libc++ instead.
The glibc requirement is also not changed because we don't
currently use any of the symbols from the newer version.

BUG= 751812 
R=dpranke@chromium.org,thestig@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.linux:linux_arm

Change-Id: I89da578852fe0f7bfd27ffc08fda99e3b4df239e
Reviewed-on: https://chromium-review.googlesource.com/598737
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516093}
[modify] https://crrev.com/97f5f9df69889a313470a8530a8a724cf17cca90/build/config/sysroot.gni
[modify] https://crrev.com/97f5f9df69889a313470a8530a8a724cf17cca90/build/linux/sysroot_scripts/install-sysroot.py

Comment 17 by thomasanderson@chromium.org, Nov 13 2017

Status: Fixed (was: Started)

Comment 18 by machenb...@chromium.org, Nov 15 2017

Blockedon: 785170
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d39d46571bbca555e8cfa090dac19c1f8c09fcf

commit 1d39d46571bbca555e8cfa090dac19c1f8c09fcf
Author: Milko Leporis <milko.leporis@mips.com>
Date: Mon Nov 20 18:18:44 2017

Support installing sysroot for mips64el for Linux

Change adds support for installing Debian Stretch sysroot for mips64el.

BUG= 751812 

Change-Id: Iaa32d0b0701b17a49e0ac735134ad85cf746fe23
Reviewed-on: https://chromium-review.googlesource.com/776873
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517863}
[modify] https://crrev.com/1d39d46571bbca555e8cfa090dac19c1f8c09fcf/build/linux/sysroot_scripts/install-sysroot.py

Comment 20 by machenb...@chromium.org, Nov 27 2017

Blockedon: 788679
►

Sign in to add a comment