Right now, the Chromebook added notification is shown even if the user enabled the feature using the setup app. We should only show this notification if EasyUnlock is enabled through sync.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3e8ece8271886809b1f2f3eece110aecd154b82 commit a3e8ece8271886809b1f2f3eece110aecd154b82 Author: Tim Song <tengs@chromium.org> Date: Wed Aug 09 06:13:25 2017 [EasyUnlock] Add easy_unlock.enabled pref and sync it to local state. Previously, the login screen looks at the presence of the hardlock local pref to determine if the user has set up EasyUnlock. This was a very unreliable and unintuitive thing to rely on, so we now explicitly have an easy_unlock.enabled pref. For easy of merging, this CL also fixes a notification bug when setting up EasyUnlock. BUG=746945, 751808 Change-Id: I437bcd3dc5f9d5e113b22a9861467f35ec1e7d62 Reviewed-on: https://chromium-review.googlesource.com/599349 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#492850} [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/chrome/browser/signin/easy_unlock_service.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/chrome/browser/signin/easy_unlock_service_regular.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/chrome/browser/signin/easy_unlock_service_regular.h [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/chrome/browser/signin/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_local_state_pref_manager.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_local_state_pref_manager.h [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_local_state_pref_manager_unittest.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_pref_manager.h [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_pref_names.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_pref_names.h [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_profile_pref_manager.cc [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_profile_pref_manager.h [modify] https://crrev.com/a3e8ece8271886809b1f2f3eece110aecd154b82/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
Merging in bug 746945.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ce66c72793d1654aa3a30fcd739673ca50b535a commit 0ce66c72793d1654aa3a30fcd739673ca50b535a Author: Tim Song <tengs@chromium.org> Date: Wed Aug 09 18:23:54 2017 [EasyUnlock] Add easy_unlock.enabled pref and sync it to local state. Previously, the login screen looks at the presence of the hardlock local pref to determine if the user has set up EasyUnlock. This was a very unreliable and unintuitive thing to rely on, so we now explicitly have an easy_unlock.enabled pref. For easy of merging, this CL also fixes a notification bug when setting up EasyUnlock. BUG=746945, 751808 TBR=tengs@chromium.org (cherry picked from commit a3e8ece8271886809b1f2f3eece110aecd154b82) Change-Id: I437bcd3dc5f9d5e113b22a9861467f35ec1e7d62 Reviewed-on: https://chromium-review.googlesource.com/599349 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492850} Reviewed-on: https://chromium-review.googlesource.com/609120 Reviewed-by: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#406} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/chrome/browser/signin/easy_unlock_service.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/chrome/browser/signin/easy_unlock_service_regular.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/chrome/browser/signin/easy_unlock_service_regular.h [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/chrome/browser/signin/easy_unlock_service_signin_chromeos.h [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_local_state_pref_manager.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_local_state_pref_manager.h [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_local_state_pref_manager_unittest.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_pref_manager.h [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_pref_names.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_pref_names.h [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_profile_pref_manager.cc [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_profile_pref_manager.h [modify] https://crrev.com/0ce66c72793d1654aa3a30fcd739673ca50b535a/components/proximity_auth/proximity_auth_profile_pref_manager_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Aug 9 2017