New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751807 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: ----
Pri: 1
Type: ----

Blocking:
issue 805543



Sign in to add a comment

Migrate findIt from Cloud Endpoints Frameworks v1 to v2

Project Member Reported by st...@chromium.org, Aug 2 2017

Issue description

Cloud Endpoints Frameworks v1 is deprecated as of August 2, 2017.
The v1 Endpoints Frameworks will cease to serve traffic on August 2, 2018.

https://cloud.google.com/endpoints/docs/frameworks/legacy/v1/python/migrating
 
Blocking: 805543
Summary: Migrate findIt from Cloud Endpoints Frameworks v1 to v2 (was: Migrate from Cloud Endpoints Frameworks v1 to v2)

Comment 2 by st...@chromium.org, May 2 2018

NextAction: 2018-05-31
Revisit by end of month to figure out a plan.
The NextAction date has arrived: 2018-05-31

Comment 4 by st...@chromium.org, Jun 4 2018

Labels: -Pri-3 Pri-1
NextAction: 2018-06-08
Owner: st...@chromium.org
Status: Assigned (was: Available)
The NextAction date has arrived: 2018-06-08

Comment 6 by st...@chromium.org, Jun 18 2018

NextAction: 2018-06-20
The NextAction date has arrived: 2018-06-20
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/204627d4ca2ea3f42b12d29c2e647bf50538b32f

commit 204627d4ca2ea3f42b12d29c2e647bf50538b32f
Author: Shuotao Gao <stgao@chromium.org>
Date: Thu Jun 21 17:42:36 2018

[Findit] Split main.py into three for different modules.

Because Findit uses App Engine pipeline framework which uses __import__ to load
python modules (pipeline classes) dynamically at runtime, it has some conflict
with the usage of Luci python components/. This CL is to split main.py so that
components/ is only used by Findit modules that do not execute pipelines.

Bug:  751807 
Change-Id: Ied0101e7d26327f18ae9c3bfd4711f2142a9ff7d
Reviewed-on: https://chromium-review.googlesource.com/1109202
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/gae_libs/appengine_util.py
[delete] https://crrev.com/3d1f35687498aa4a7cd946d1ef5ce66a8916c27d/appengine/findit/handlers/version.py
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/dispatch.yaml
[add] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/test/main_test.py
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/handlers/flake/detection/detect_flakes.py
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/module-waterfall-frontend.yaml
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/gae_libs/handlers/test/base_handler_test.py
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/module-waterfall-backend.yaml
[add] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/backend_main.py
[delete] https://crrev.com/3d1f35687498aa4a7cd946d1ef5ce66a8916c27d/appengine/findit/handlers/test/step_by_step_comparison_test.py
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/gae_libs/test/appengine_util_test.py
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/module-flake-detection-backend.yaml
[modify] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/app.yaml
[delete] https://crrev.com/3d1f35687498aa4a7cd946d1ef5ce66a8916c27d/appengine/findit/main.py
[add] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/frontend_main.py
[add] https://crrev.com/204627d4ca2ea3f42b12d29c2e647bf50538b32f/appengine/findit/default_main.py
[delete] https://crrev.com/3d1f35687498aa4a7cd946d1ef5ce66a8916c27d/appengine/findit/handlers/step_by_step_comparison.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/170a44fa889031b51a058f6119b9039601cc5d09

commit 170a44fa889031b51a058f6119b9039601cc5d09
Author: Shuotao Gao <stgao@chromium.org>
Date: Thu Jun 21 18:28:05 2018

[Findit] Reduce dependency on endpoints to only findit_api.py

With this change, only the default module will depend on endpoints lib.

Bug:  751807 
Change-Id: Ib7bf3991b5b10f521482df11ebea7ec946c1a515
Reviewed-on: https://chromium-review.googlesource.com/1110442
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/170a44fa889031b51a058f6119b9039601cc5d09/appengine/findit/common/constants.py
[modify] https://crrev.com/170a44fa889031b51a058f6119b9039601cc5d09/appengine/findit/common/test/acl_test.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7a051cb5c405782c43b559002560d43dcb7a2be5

commit 7a051cb5c405782c43b559002560d43dcb7a2be5
Author: Shuotao Gao <stgao@chromium.org>
Date: Thu Jun 21 19:14:38 2018

[Findit] Remove duplicate code in build_util.py

Bug:  751807 
Change-Id: I4756e94a60e40658a70feb259f351b3e0cb39f70
Reviewed-on: https://chromium-review.googlesource.com/1110520
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/handlers/handlers_util.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/handlers/triage_suspected_cl.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/waterfall/test/build_util_test.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/findit_api.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/waterfall/suspected_cl_util.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/util_scripts/remote_queries/detection_rate_at_step_level.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/waterfall/build_util.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/test/findit_api_test.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/services/test_failure/test_try_job.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/handlers/build_failure.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/waterfall/test/suspected_cl_util_test.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/model/base_build_model.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/handlers/culprit.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/7a051cb5c405782c43b559002560d43dcb7a2be5/appengine/findit/handlers/test/build_failure_test.py

Comment 12 by st...@chromium.org, Jun 21 2018

Cc: smut@chromium.org
Status: Verified (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c0371e666d752e8b7c6d4e33ea5d820f2500e078

commit c0371e666d752e8b7c6d4e33ea5d820f2500e078
Author: Shuotao Gao <stgao@chromium.org>
Date: Thu Jun 21 21:23:30 2018

[Findit] Update legacy url in UI templates.

Bug:  751807 
Change-Id: I5bf11c1ea7c768b254711f6dc8917a739c8a81ef
Reviewed-on: https://chromium-review.googlesource.com/1110879
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/c0371e666d752e8b7c6d4e33ea5d820f2500e078/appengine/findit/templates/try_job_dashboard.html
[modify] https://crrev.com/c0371e666d752e8b7c6d4e33ea5d820f2500e078/appengine/findit/templates/build_failure.html

Sign in to add a comment