New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751803 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

NewTabPageTestCase fails on iPhone 6 Plus, iOS 10

Project Member Reported by liaoyuke@chromium.org, Aug 2 2017

Issue description

testRotation, testOmnibox and testScrollToolbar fail consistently on the first run, but succeeds on re-trying.

Please see FYI bot: https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/EarlGrey-simulator.

Examples:
https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/EarlGrey-simulator/builds/8967
https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/EarlGrey-simulator/builds/8966

This is right now blocking running these tree tests on iOS 11 bots. Assigning to justincohen@ who is NTP owner.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2518168ae4596abb5149c8a7761b3a5ca20526

commit ff2518168ae4596abb5149c8a7761b3a5ca20526
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Aug 02 21:22:12 2017

Disable 3 tests in NewTabPage test case on iOS 11.

testRotation, testOmnibox and testScrollToolbar fail on iPhone 6 Plus,
iOS 10, and this CL disables them on iOS 11 to unblock running the test
case on iPhone 6 Plus, iOS 11.

Bug:  751803 
Change-Id: Ibcda582e2f86617b1fcea89a5296dde182b9b81c
Reviewed-on: https://chromium-review.googlesource.com/598646
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491503}
[modify] https://crrev.com/ff2518168ae4596abb5149c8a7761b3a5ca20526/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm

Labels: zine-triaged
Labels: -Pri-1 -ReleaseBlock-Beta -M-62 -Proj-iOS11 Pri-2
Not specifically related to iOS 11, so shouldn't be a RBB for iOS 11.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf73dffbb2e6544c1b9ff46bf90ad6a6a014a4ce

commit bf73dffbb2e6544c1b9ff46bf90ad6a6a014a4ce
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Aug 08 01:10:47 2017

Reenable new tab page tests on iOS 11.

These tests also fail on iOS 10, not specifically related to iOS 11.

Bug:  751803 
Change-Id: I63c15791dc7eb278c60e15caff0e123d571de070
Reviewed-on: https://chromium-review.googlesource.com/604867
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492486}
[modify] https://crrev.com/bf73dffbb2e6544c1b9ff46bf90ad6a6a014a4ce/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm

Blocking: -747114
Owner: ----
Status: Available (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled
Status: WontFix (was: Available)

Sign in to add a comment