New issue
Advanced search Search tips

Issue 751798 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Border radius masks are not applied for transformed children

Project Member Reported by schenney@chromium.org, Aug 2 2017

Issue description

Chrome Version: 61.0.3129.0
OS: All using Blink

What steps will reproduce the problem?
(1) Open the attached file

What is the expected result?
A green square with rounded corners

What happens instead?
A green square without rounded corners

This regressed with the following change.
https://chromium.googlesource.com/chromium/src/+/e4208d105f75a14f9719ae35c19d7104f08a5f0b
 
composited-scaled-child-with-border-radius-parent-clip.html
391 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/973b7b9212b8d7b956d50f00792995d9712e4186

commit 973b7b9212b8d7b956d50f00792995d9712e4186
Author: Stephen Chenney <schenney@chromium.org>
Date: Fri Aug 04 15:24:55 2017

Fix border radius masks for transformed children.

A previous change starting using the compositing_bounds_ for
determining if a border radius clipping mask is required. However,
that bound does not include transformations that will be applied to
the child's layer. This change uses the child's layer bound in its
nearest clipping ancestor's space, and performs all clip testing in
that space.

Bug:  751798 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7e55c11cd54198dcfea2dc547e27133294465795
Reviewed-on: https://chromium-review.googlesource.com/539835
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492036}
[modify] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip-expected.png
[add] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip-expected.txt
[add] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip.html
[add] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip-expected.png
[add] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip-expected.txt
[add] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip.html
[modify] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt
[modify] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/LayoutTests/compositing/layer-creation/overflow-scroll-overlap.html
[modify] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/973b7b9212b8d7b956d50f00792995d9712e4186/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Labels: M-61 Merge-Request-61
Pls apply appropriate OSs label. Thank you.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 4 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 7 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad8f597ed5da223d8d829db82f2d807ae6af97a0

commit ad8f597ed5da223d8d829db82f2d807ae6af97a0
Author: Stephen Chenney <schenney@chromium.org>
Date: Mon Aug 07 15:26:49 2017

Fix border radius masks for transformed children.

M-61 Merge.

A previous change starting using the compositing_bounds_ for
determining if a border radius clipping mask is required. However,
that bound does not include transformations that will be applied to
the child's layer. This change uses the child's layer bound in its
nearest clipping ancestor's space, and performs all clip testing in
that space.

TBR=schenney@chromium.org

(cherry picked from commit 973b7b9212b8d7b956d50f00792995d9712e4186)

Bug:  751798 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7e55c11cd54198dcfea2dc547e27133294465795
Reviewed-on: https://chromium-review.googlesource.com/539835
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492036}
Reviewed-on: https://chromium-review.googlesource.com/603967
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#346}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip-expected.png
[add] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip-expected.txt
[add] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/composited-scaled-child-with-border-radius-parent-clip.html
[add] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip-expected.png
[add] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip-expected.txt
[add] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/composited-translated-child-with-border-radius-parent-clip.html
[modify] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/layer-creation/overflow-scroll-overlap-expected.txt
[modify] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/LayoutTests/compositing/layer-creation/overflow-scroll-overlap.html
[modify] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/ad8f597ed5da223d8d829db82f2d807ae6af97a0/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Status: Fixed (was: Assigned)
Android: Works as per expected behavior, Tested on Pixel XL / NJH47D. 
Issue verified on 61.0.3163.42. 

Sign in to add a comment