autotest-chrome-0.0.1-r7010.ebuild not getting updated by the bots |
|||||
Issue descriptionOriginal issue copy/paste from email: webrtc_PausePlayPeerConnections not running after updating the test name in autotest-chrome-9999.ebuild How is autotest-chrome-0.0.1-r7010.ebuild generated and how often? I had submitted a CL (https://chromium-review.googlesource.com/c/588369) last week to fix the test name in autotest-chrome-9999.ebuild but I see the autotest-chrome-0.0.1-r7010.ebuild file still shows old names. Do the contents of autotest-chrome-0.0.1-r7010.ebuild matter? If so, how do we ensure that it gets updated with the new test name? https://cs.corp.google.com/search/?q=webrtc_PausePlayPeerConnections+file:%5Esrc/third_party/chromiumos-overlay/chromeos-base/+package:%5Echromeos_public$&type=cs Email updates from vapier and akeshet: vapier - that ebuild should have been updated long ago by the bots akeshet - Sounds like a bug in uprev logic...
,
Aug 2 2017
webrtc_PausePlayPeerConnections is showing up in https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/15589/steps/PublishUprevChanges/logs/stdio and other successful CQ builds over the last few days. Does this mean that the test ought to be running and that the issue might be somewhere else?
,
Aug 2 2017
This is odd. The uprev logic should only be dealing with when modifications are made in the test directories. If the ebuild itself is updated (as is the case here), it should be automatically updated by the CrOS ebuild system. Is autotest-chrome upreved automatically when we make a change to the 9999 ebuild?
,
Aug 2 2017
@Comment#1: The two entries for the webrtc_PausePlayPeerConnections at the end is because the .audio and .video is being stripped off (off the old ebuild)
,
Aug 3 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4ad25dcfdcffc5f84be6c50b9634e496b67504c7 commit 4ad25dcfdcffc5f84be6c50b9634e496b67504c7 Author: Prashant Malani <pmalani@google.com> Date: Fri Aug 04 02:23:18 2017 portage_util: Use unstable ebuild to determine subdirs The stable version of the ebuild will miss changes to the list of tests themselves. Also, check that the list of subdirs hasn't been changed b/w stable and unstable. If so, uprev without checking further. BUG= chromium:751791 TEST=cros_mark_as_stable commit --all --boards=samus after cros_workon-samus start autotest-chrome Change-Id: I28bec32f31d986fdcc58f00894727fdd5218f88b Reviewed-on: https://chromium-review.googlesource.com/598943 Commit-Ready: Prashant Malani <pmalani@google.com> Tested-by: Prashant Malani <pmalani@google.com> Reviewed-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/4ad25dcfdcffc5f84be6c50b9634e496b67504c7/lib/portage_util.py
,
Aug 4 2017
I submitted a patch which should address this. Kindly let me know if the problem persists. I am going to go ahead and mark the issue as fixed.
,
Aug 4 2017
The package "autotest-tests-guado" has not been built, since its day 1. We were expecting it would be automatically built, which was not. Ebuild: https://chromium-review.googlesource.com/c/527264/ Test: https://chromium-review.googlesource.com/c/521865/ Do you see this bug fix can improve the situation? I will monitor the new official builds if it is that case.
,
Aug 4 2017
ebuilds don't get automatically built just because they exist. they need to be depended on by something else to get pulled in. i.e. you need to define virtual/autotest-tests in your board overlay.
,
Aug 9 2017
So my goal is to add a new autotest-tests-guado ebuild, only for guado, as part of the default packages built for guado. I explored a few options of making it happen, and please advise what would be a right one. 1. Adding RDEPEND in chromeos-bsp-guado-0.0.1.ebuild 2. Adding a conditional RDEPEND in chromeos-base/autotest-all 3. Adding a conditional PACKAGES+=() in build_packages script 4. None of the above. If your answer is 4, can you please specify which file is the right place to insert this dependency?
,
Aug 9 2017
did you do what i suggested in comment #9 ? you should start there: > you need to define virtual/autotest-tests in your board overlay.
,
Aug 9 2017
Re #11: Thanks. New approach is to create an ebuild virtual/autotest-tests/autotest-tests-3.ebuild Under review in CL 428229
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dgarr...@chromium.org
, Aug 2 2017