New issue
Advanced search Search tips

Issue 751787 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Upload Component versions to Crash/UMA

Project Member Reported by waff...@chromium.org, Aug 2 2017

Issue description

Life would be better if Crash and UMA could split based on the presence/absence of components and track regressions caused by component pushes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/404c74d7436c836356f0803afad8c9c63fa3c0a1

commit 404c74d7436c836356f0803afad8c9c63fa3c0a1
Author: Joshua Pawlicki <waffles@google.com>
Date: Mon Aug 14 17:46:16 2017

Upload component versions to Crash and UMA.

Bug:  751787 
Change-Id: Ie3f3c78a009edbdabda09b73ee3b03754ff60a8e
Reviewed-on: https://chromium-review.googlesource.com/598649
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494091}
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/component_updater/component_updater_service.h
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/component_updater/component_updater_service_internal.h
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/component_updater/mock_component_updater_service.h
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/metrics/BUILD.gn
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/metrics/DEPS
[add] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/metrics/component_metrics_provider.cc
[add] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/metrics/component_metrics_provider.h
[add] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/metrics/component_metrics_provider_unittest.cc
[modify] https://crrev.com/404c74d7436c836356f0803afad8c9c63fa3c0a1/components/metrics/proto/system_profile.proto

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d7260b2352d7e5539160a015e62d828e4b3278e

commit 8d7260b2352d7e5539160a015e62d828e4b3278e
Author: Eric Stevenson <estevenson@chromium.org>
Date: Mon Aug 14 19:27:59 2017

Revert "Upload component versions to Crash and UMA."

This reverts commit 404c74d7436c836356f0803afad8c9c63fa3c0a1.

Reason for revert: Adds static initializer on Android (crbug/755254).

Original change's description:
> Upload component versions to Crash and UMA.
> 
> Bug:  751787 
> Change-Id: Ie3f3c78a009edbdabda09b73ee3b03754ff60a8e
> Reviewed-on: https://chromium-review.googlesource.com/598649
> Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494091}

TBR=asvitkine@chromium.org,sorin@chromium.org,waffles@chromium.org

Change-Id: Ib3b9b8c350dab8f6e2c1104d5f77fd8e64f5c041
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  751787 
Reviewed-on: https://chromium-review.googlesource.com/614241
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494132}
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/component_updater/component_updater_service.h
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/component_updater/component_updater_service_internal.h
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/component_updater/mock_component_updater_service.h
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/metrics/BUILD.gn
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/metrics/DEPS
[delete] https://crrev.com/bc22e664bca9ff775783bcac786bb35d84cd9de4/components/metrics/component_metrics_provider.cc
[delete] https://crrev.com/bc22e664bca9ff775783bcac786bb35d84cd9de4/components/metrics/component_metrics_provider.h
[delete] https://crrev.com/bc22e664bca9ff775783bcac786bb35d84cd9de4/components/metrics/component_metrics_provider_unittest.cc
[modify] https://crrev.com/8d7260b2352d7e5539160a015e62d828e4b3278e/components/metrics/proto/system_profile.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0499ac840b2f4234c0860c951750dd4bcb0bd225

commit 0499ac840b2f4234c0860c951750dd4bcb0bd225
Author: Joshua Pawlicki <waffles@google.com>
Date: Thu Aug 17 18:29:07 2017

Reland Upload component versions to Crash and UMA.

Original Change @ https://chromium-review.googlesource.com/c/598649

Bug:  751787 
Change-Id: Iddeef25bed60ddc6f748d95d05271596735aa31c
Reviewed-on: https://chromium-review.googlesource.com/616860
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495238}
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/chrome/browser/BUILD.gn
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/component_updater/component_updater_service.h
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/component_updater/component_updater_service_internal.h
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/component_updater/mock_component_updater_service.h
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/metrics/BUILD.gn
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/metrics/DEPS
[add] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/metrics/component_metrics_provider.cc
[add] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/metrics/component_metrics_provider.h
[add] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/metrics/component_metrics_provider_unittest.cc
[modify] https://crrev.com/0499ac840b2f4234c0860c951750dd4bcb0bd225/components/metrics/proto/system_profile.proto

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f11bb8fa13e60b6242efe7677684abb31050df

commit 54f11bb8fa13e60b6242efe7677684abb31050df
Author: Roman Kuksin <rkuksin@yandex-team.ru>
Date: Mon Oct 23 18:02:28 2017

add missing test to gn

Bug:  751787 
Change-Id: I16a538991e0700e1c5aeb63311438497eb16c568
Reviewed-on: https://chromium-review.googlesource.com/730004
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510844}
[modify] https://crrev.com/54f11bb8fa13e60b6242efe7677684abb31050df/components/metrics/BUILD.gn

Sign in to add a comment