New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751783 link

Starred by 1 user
Status: Fixed
Owner:
█ tengs@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ sacomoto@chromium.org
█ dschuyler@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 747601



Sign in to add a comment

EasyUnlock v2: Turn off settings dialog has broken HTML

Project Member Reported by tengs@chromium.org, Aug 2 2017 
There turn off dialog displays an HTML string:

"hidden="[[isButtonBarHidden_(status_)]]">"

This was inadvertently added during this refactor:
https://chromium.googlesource.com/chromium/src/+/81c6fb8cfb6514216cac0107767e35884573a59b

As this is a recent change, this doesn't need to be merged into M61.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50f713323c98e95aa7300931c55fd473113c4ea0

commit 50f713323c98e95aa7300931c55fd473113c4ea0
Author: Tim Song <tengs@chromium.org>
Date: Wed Aug 02 22:10:24 2017

[EasyUnlock] Fix HTML typo in turn off dialog UI.

BUG= 751783 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifefe73dbc4039201f32fef25fa48f04541d6af20
Reviewed-on: https://chromium-review.googlesource.com/598436
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491524}
[modify] https://crrev.com/50f713323c98e95aa7300931c55fd473113c4ea0/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html

Comment 2 by tengs@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment