Clean up filtering of child gesture scroll events during root overscroll |
|||
Issue descriptionA gesture scroll stream targeted to a child frame may bubble to the root and start an overscroll gesture. During the overscroll in the root, we must prevent the child from consuming scroll events. Currently, we have the child send its gesture scroll updates to the root so that the root has a chance to filter them. The updates to scroll bubbling from scroll latching will make this unnecessary, as the child will no longer try to consume the events.
,
Sep 5 2017
,
Sep 5 2017
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91083aacdec11983cfa697d832f68b9a3ff1fedf commit 91083aacdec11983cfa697d832f68b9a3ff1fedf Author: Kevin McNee <mcnee@chromium.org> Date: Mon Oct 02 20:48:01 2017 Put filtering of a child's scroll events behind scroll latching flag. In order to prevent a child frame from scrolling during an overscroll gesture in the root, we give the root a chance to consume the child's GestureScrollUpdate events before the child. With the new scroll latching behaviour, this is unnecessary, as the child would not consume scroll in this case. We now only filter the child's GestureScrollUpdates when scroll latching is disabled. Bug: 751782 Change-Id: I8aa7d652dda4d8bc5768d659019dd750bf44ad33 Reviewed-on: https://chromium-review.googlesource.com/675167 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#505775} [modify] https://crrev.com/91083aacdec11983cfa697d832f68b9a3ff1fedf/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/91083aacdec11983cfa697d832f68b9a3ff1fedf/content/browser/renderer_host/render_widget_host_view_child_frame.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by mcnee@chromium.org
, Aug 2 2017