New issue
Advanced search Search tips

Issue 751775 link

Starred by 1 user
Status: Fixed
Owner:
liber...@chromium.org
Closed: Aug 2017
Cc:
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

race condition in DialogOverlayImpl constructor

Project Member Reported by liber...@chromium.org, Aug 2 2017 
DialogOverlayImpl posts the initialization of DialogOverlayCore to the overlay thread, then declares that DialogOverlayCore is initialized.

unfortunately, the compiler ignored those comments and did not insert the appropriate synchronization.  as a result, it's possible to send a window token to the core before it's ready.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36d3059d37aa1db3c79359e644d03b6f5774b9e3

commit 36d3059d37aa1db3c79359e644d03b6f5774b9e3
Author: liberato@chromium.org <liberato@chromium.org>
Date: Mon Aug 07 19:40:48 2017

Fix initialization race in DialogOverlayImpl

DialogOverlayImpl previously posted initialization of
DialogOverlayCore to the overlay thread, then didn't wait before
using it.

This CL adds synchronization.

Bug:  751775 
Change-Id: Ia32dcfd7a32a1542974b121c934567bd213f901e
Reviewed-on: https://chromium-review.googlesource.com/598668
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492384}
[modify] https://crrev.com/36d3059d37aa1db3c79359e644d03b6f5774b9e3/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayImpl.java

Comment 2 by liber...@chromium.org, Aug 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment