New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751761 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

launcher search doesn't highlight matched query string

Project Member Reported by warx@chromium.org, Aug 2 2017

Issue description

Please see the attachment, highlight is missing on files search.

 
Screenshot from 2017-08-02 10:15:11.png
53.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44018e43774bbd5869fddcede3f59fd7e26a8642

commit 44018e43774bbd5869fddcede3f59fd7e26a8642
Author: Qiang Xu <warx@chromium.org>
Date: Thu Aug 03 01:32:46 2017

app_list: update searchbox result row, render text part

changes:
(1) Enable launcher search result title tags, this will fix
 crbug.com/751761 .
(2) Update card background color to #FAFAFC, not #FFFFFF.
(3) update single line row (for omnibox non-url search result) and
double lines row specs for render text.

single line row specs: https://screenshot.googleplex.com/hBwCTmKNq4d
double lines row specs: https://screenshot.googleplex.com/9pSZ2p2BVdo

Test screenshot:
screenshot 1: https://screenshot.googleplex.com/KQRCUAF0EXS
screenshot 2: https://screenshot.googleplex.com/NxdAOS7GeMm

Test: tested with fullscreen app list flag
Bug: 750690,  751761 
Change-Id: I4104d7b9056bfbc555ce2bb10867383157963c0a
Reviewed-on: https://chromium-review.googlesource.com/596851
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491598}
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.h
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/chrome/browser/ui/app_list/search/omnibox_result.h
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/app_list_constants.h
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/search_result.h
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/views/search_result_tile_item_list_view.h
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/views/search_result_view.cc
[modify] https://crrev.com/44018e43774bbd5869fddcede3f59fd7e26a8642/ui/app_list/views/search_result_view.h

Comment 2 by warx@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3556d35d57fe8cb2e27bbf99406821bc46fc55e4

commit 3556d35d57fe8cb2e27bbf99406821bc46fc55e4
Author: Maajid <maajid@chromium.org>
Date: Fri Aug 04 21:28:54 2017

app_list: update searchbox result row, render text part

changes:
(1) Enable launcher search result title tags, this will fix
 crbug.com/751761 .
(2) Update card background color to #FAFAFC, not #FFFFFF.
(3) update single line row (for omnibox non-url search result) and
double lines row specs for render text.

single line row specs: https://screenshot.googleplex.com/hBwCTmKNq4d
double lines row specs: https://screenshot.googleplex.com/9pSZ2p2BVdo

Test screenshot:
screenshot 1: https://screenshot.googleplex.com/KQRCUAF0EXS
screenshot 2: https://screenshot.googleplex.com/NxdAOS7GeMm

TBR=warx@chromium.org

(cherry picked from commit 44018e43774bbd5869fddcede3f59fd7e26a8642)

Test: tested with fullscreen app list flag
Bug: 750690,  751761 
Change-Id: I4104d7b9056bfbc555ce2bb10867383157963c0a
Reviewed-on: https://chromium-review.googlesource.com/596851
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491598}
Reviewed-on: https://chromium-review.googlesource.com/602686
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#325}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.h
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/chrome/browser/ui/app_list/search/omnibox_result.h
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/app_list_constants.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/app_list_constants.h
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/search_result.h
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/views/search_result_tile_item_list_view.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/views/search_result_tile_item_list_view.h
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/views/search_result_view.cc
[modify] https://crrev.com/3556d35d57fe8cb2e27bbf99406821bc46fc55e4/ui/app_list/views/search_result_view.h

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment