New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751759 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 751326

Blocking:
issue 751321



Sign in to add a comment

Security review for out-of-process heap-profiling

Project Member Reported by erikc...@chromium.org, Aug 2 2017

Issue description

Right now, the OOP-HP is in the prototyping phase, and the IPC layer is going through fast changes. OOP-HP is also behind a compile-time flag right now.

Rather than attempting to make each iteration secure, can we get a full security review before removing the compile time flag?
 
Blockedon: 751326
Blocking: 751321
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91b2785a2a3b8587d6942cd0443a51ad4f0889c2

commit 91b2785a2a3b8587d6942cd0443a51ad4f0889c2
Author: erikchen <erikchen@chromium.org>
Date: Thu Aug 17 19:28:37 2017

Finalize the interface for the profiling service.

While there may still be minor changes in the future, the basic structure of the
communication model has been established and will not change.

Bug:  751759 
Change-Id: Ibb6b97997481203be9f68a9bbbf3495bc38a53d4
Reviewed-on: https://chromium-review.googlesource.com/618799
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495278}
[modify] https://crrev.com/91b2785a2a3b8587d6942cd0443a51ad4f0889c2/chrome/common/profiling/memlog.mojom
[modify] https://crrev.com/91b2785a2a3b8587d6942cd0443a51ad4f0889c2/chrome/common/profiling/memlog_client.mojom

Status: Fixed (was: Untriaged)

Sign in to add a comment