Issue metadata
Sign in to add a comment
|
loading.desktop.network_service is failing on linux perf FYI bot because of service worker-related bad messages |
||||||||||||||||||||||||
Issue descriptionLink: https://build.chromium.org/p/chromium.perf.fyi/builders/Mojo%20Linux%20Perf/builds/2091 Two test cases are failing: - Bhaskar - AirBnB There are such messages in the log: [12359:12392:0802/053951.632429:ERROR:bad_message.cc(23)] Terminating renderer for bad IPC message, reason 51 Reason 51 is SWDH_REGISTER_CANNOT. To run the test locally, please do: - build chrome in <path-to-src>/out/Release - run: tools/perf/run_benchmark -v --browser=release --pageset-repeat=1 --story-filter=AirBnB loading.desktop.network_service Hi, Kinuko and Matt. Would you please help to triage this bug? Thanks!
,
Aug 23 2017
Taking a look.
,
Aug 23 2017
It's crashing at [4983:5012:0823/145338.374900:ERROR:service_worker_dispatcher_host.cc(517)] Origins don't match: http://www.airbnb.com/ vs https://www.airbnb.com/ [4983:5012:0823/145338.374936:ERROR:bad_message.cc(23)] Terminating renderer for bad IPC message, reason 57 I can repro in a browser by navigating to "http://www.airbnb.com". However if I go to "https://www.airbnb.com" it works. So I think the problem just has to do with the service worker machinery not handling redirects well yet. It'll be a while before this is working end-to-end, see issue 715640 .
,
Aug 23 2017
,
Aug 23 2017
,
Sep 29 2017
Now the crash has changed probably thanks to horo@ implementing redirects. Now the crash is: [1:1:0929/144628.011837:FATAL:service_worker_subresource_loader.cc(63)] Check failed: !resource_request.request_body. #0 0x7f12ca9ece57 base::debug::StackTrace::StackTrace() #1 0x7f12caa14461 logging::LogMessage::~LogMessage() #2 0x7f12c79244c4 content::ServiceWorkerSubresourceLoader::StartRequest() #3 0x7f12c7924398 content::ServiceWorkerSubresourceLoader::ServiceWorkerSubresourceLoader() This is also a known issue: SW subresource loader doesn't yet support request bodies.
,
Oct 25 2017
Currently, the following browser tests crash when running with --enable-features=NetworkService flag: WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsVP8 WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsVP9 WebrtcEventLogApiTest.TestStartStopWebRtcEventLogging WebrtcEventLogApiTest.TestStartTimedWebRtcEventLogging The stack trace shows: service_worker_subresource_loader.cc(186)] Check failed: !resource_request.request_body
,
Oct 25 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Dec 4 2017
It seems Bhaskar and AirBnB pass now on the bot: For example: https://chromium-swarm.appspot.com/task?id=3a3b77b2f6077310&refresh=10&show_raw=1 Matt: Is there more work that we need to do for this bug that I am not aware of? Shall we close it? Thanks!
,
Dec 5 2017
Ah the crash no longer happens since we no longer try to build a blob to send as the request body over IPC to the renderer. Request body support isn't yet complete (have to teach Blink to read data pipes), and I'm working on that, but it's OK to close this as the perf bot failure no longer happens.
,
Dec 5 2017
Thanks Matt! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by falken@chromium.org
, Aug 3 2017