New issue
Advanced search Search tips

Issue 751720 link

Starred by 1 user
Status: Fixed
Owner:
drubery@chromium.org
Closed: Dec 10
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Minor suggestions for improving chrome://safe-browsing

Project Member Reported by vakh@chromium.org, Aug 2 2017 
Here are a few suggestions:
1. Consider adding sub-sections for the database and update manager.
2. Database size in bytes -> Database size (in bytes)
3. Add the next update time
4. Change the following:
   SafeBrowsing.V4Database.Size.IpMalware: 106
   Store update status: 0
   to:
   <b>IpMalware</b>:
   Size (in bytes): 106
   Update status: 0
5. Consider reducing the amount of bold text.
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 2 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "hkamila@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by vakh@chromium.org, Oct 2 2017

Owner: vakh@chromium.org
Status: Assigned (was: Untriaged)
CL https://chromium-review.googlesource.com/c/chromium/src/+/636087 addresses most of it.

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Comment 5 by vakh@chromium.org, Jun 19 2018

Cc: vakh@chromium.org
Owner: drubery@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c24dd4b704f651fac616f29156ac8183eb21ae3

commit 3c24dd4b704f651fac616f29156ac8183eb21ae3
Author: Daniel Rubery <drubery@chromium.org>
Date: Sat Dec 08 03:44:14 2018

Minor UI improvements to the Database Manager on chrome://safe-browsing

The major improvement is to massively reduce the amount of bold text,
so that it's much easier to find information about each list. This CL
also adds the next update time to the same panel.

Render: https://screenshot.googleplex.com/fPobRCMrFDm

Bug:  751720 
Change-Id: Idd91f821e919be0230c355a5f6dbd5016a171da0
Reviewed-on: https://chromium-review.googlesource.com/c/1368787
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614938}
[modify] https://crrev.com/3c24dd4b704f651fac616f29156ac8183eb21ae3/components/safe_browsing/db/v4_store.cc
[modify] https://crrev.com/3c24dd4b704f651fac616f29156ac8183eb21ae3/components/safe_browsing/db/v4_update_protocol_manager.cc
[modify] https://crrev.com/3c24dd4b704f651fac616f29156ac8183eb21ae3/components/safe_browsing/proto/webui.proto
[modify] https://crrev.com/3c24dd4b704f651fac616f29156ac8183eb21ae3/components/safe_browsing/web_ui/safe_browsing_ui.cc

Comment 7 by drubery@chromium.org, Dec 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment