Issue 751696 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	csharrison@chromium.org
Closed:	Aug 2017
Cc:	shivanisha@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

SubresourceFilter: activation list matching happily accepts matching with NONE

Project Member Reported by csharrison@chromium.org, Aug 2 2017

Issue description

See SubresourceFilterSafeBrowsingActivationThrottle::DoesMainFrameURLSatisfyActivationConditions.

If the condition we're matching on is ActivationList, we will return true if both the list and the config are None. This goes against intuition, where None should mean nothing should match.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a05e40bca619b248e280f206096859cc607f5afd

commit a05e40bca619b248e280f206096859cc607f5afd
Author: Charles Harrison <csharrison@chromium.org>
Date: Thu Aug 03 14:42:51 2017

[subresource_filter] ActivationList::NONE match should be impossible

Bug:  751696 
Change-Id: Ic306f3ce59d38e752503304f62bcd26e39b284cb
Reviewed-on: https://chromium-review.googlesource.com/598988
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491736}
[add] https://crrev.com/a05e40bca619b248e280f206096859cc607f5afd/chrome/browser/subresource_filter/subresource_filter_configuration_unittest.cc
[modify] https://crrev.com/a05e40bca619b248e280f206096859cc607f5afd/chrome/test/BUILD.gn
[modify] https://crrev.com/a05e40bca619b248e280f206096859cc607f5afd/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc

Comment 2 by csharrison@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)

►

Issue 751696 link

Issue metadata

SubresourceFilter: activation list matching happily accepts matching with NONE

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

Comment 1 Deleted

Comment 2 by csharrison@chromium.org, Aug 3 2017

Comment 2 Deleted

Sign in to add a comment