Issue metadata
Sign in to add a comment
|
[Suggestions favicons] Clear up code for old favicon server when not needed any more |
||||||||||||||||||||
Issue descriptionorg.chromium.chrome.browser.suggestions.ImageFetcher has two ways of fetching favicons: - from the old (social) favicon server - from the new favicon server v2. When we completely switch to the new server, we should remove the previous code: - simplify org.chromium.chrome.browser.suggestions.ImageFetcher - remove ensureIconIsAvailable from FaviconHelper. This is unlikely to happen before M62 hits Stable.
,
Nov 28 2017
This probably goes away by itself with Jardin. Keeping around for the improbable case that it does not. Update about the situation: - Due to jardin, we haven't switched to the new server on Android (because of process work that would bring no significant improvement). - If we still leave the old Zine interface on tablets or other rare-case situations, it seems reasonable to switch to the new server on Android and clean this up.
,
Nov 28 2017
,
Oct 19
Moving to the current milestone as a clean up after issue 714109
,
Oct 19
,
Oct 19
,
Oct 19
The patch is out for review. https://chromium-review.googlesource.com/c/chromium/src/+/1291840 Turns out this was small.
,
Oct 23
The NextAction date has arrived: 2018-10-23
,
Oct 23
,
Nov 8
,
Nov 20
The NextAction date has arrived: 2018-11-20
,
Nov 26
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e14a87d7043513ff90c65e60c5f2e8a61175c04 commit 7e14a87d7043513ff90c65e60c5f2e8a61175c04 Author: Filip Gorski <fgorski@chromium.org> Date: Mon Nov 26 22:33:29 2018 [Zine] Old favicon code clean up Bug: 751628 Change-Id: Ief50f500266330c5ecceff718001f92bd7d4f467 Reviewed-on: https://chromium-review.googlesource.com/c/1291840 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#610962} [modify] https://crrev.com/7e14a87d7043513ff90c65e60c5f2e8a61175c04/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ImageFetcher.java [modify] https://crrev.com/7e14a87d7043513ff90c65e60c5f2e8a61175c04/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java [modify] https://crrev.com/7e14a87d7043513ff90c65e60c5f2e8a61175c04/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsUiDelegateImpl.java [modify] https://crrev.com/7e14a87d7043513ff90c65e60c5f2e8a61175c04/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/7e14a87d7043513ff90c65e60c5f2e8a61175c04/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/ImageFetcherTest.java [modify] https://crrev.com/7e14a87d7043513ff90c65e60c5f2e8a61175c04/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java
,
Nov 27
The NextAction date has arrived: 2018-11-27
,
Nov 27
,
Nov 27
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dgn@chromium.org
, Aug 4 2017Components: UI>Browser>NewTabPage
Labels: zine-triaged zine-client