New issue
Advanced search Search tips

Issue 751553 link

Starred by 1 user
Status: Fixed
Owner:
edchin@chromium.org
Closed: Oct 3
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[iOS-flag] ]Remove IsLRUSnapshotCacheEnabled()

Project Member Reported by noyau@chromium.org, Aug 2 2017 
This code has been returning NO for a long time, and is used only in one place. I believe this has been forgotten whne the rest of the LRU cache code was excised. 

Note that the behavior defaults to YES at the first memory warning

This bug is to remove all the code as well as the keepOnlyVisibleCardViewsAlive properties.

Comment 1 by sczs@chromium.org, Aug 2 2017

Status: Assigned (was: Untriaged)

Comment 2 by noyau@chromium.org, Jan 26 2018

Owner: ----
Status: Untriaged (was: Assigned)

Comment 3 by pkl@chromium.org, Jan 29 2018

Labels: -Pri-2 Pri-3
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)
edchin: do you own the snapshot code?

Comment 4 by marq@chromium.org, Oct 1 

edchin: ping?

Comment 5 by edchin@chromium.org, Oct 3

Status: Started (was: Assigned)
CL in-flight.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b77920056309e820a5a6faed6fc055a0d5b9b6f4

commit b77920056309e820a5a6faed6fc055a0d5b9b6f4
Author: edchin <edchin@chromium.org>
Date: Wed Oct 03 16:25:08 2018

[ios] Remove old LRU Snapshot Cache flag

Bug:  751553 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iaa724ae915ccb81347a7f82c41de47f64697eeee
Reviewed-on: https://chromium-review.googlesource.com/c/1257791
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596249}
[modify] https://crrev.com/b77920056309e820a5a6faed6fc055a0d5b9b6f4/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/b77920056309e820a5a6faed6fc055a0d5b9b6f4/ios/chrome/browser/experimental_flags.mm

Comment 7 by edchin@chromium.org, Oct 3

Status: Fixed (was: Started)
►

Sign in to add a comment