Issue metadata
Sign in to add a comment
|
"OmniboxViewTest.AcceptKeywordBySpace" is flaky |
||||||||||||||||||||||
Issue description"OmniboxViewTest.AcceptKeywordBySpace" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRPbW5pYm94Vmlld1Rlc3QuQWNjZXB0S2V5d29yZEJ5U3BhY2UM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Aug 2 2017
pkasting@: Can you take a look or triage further?
,
Aug 2 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7bb1d51867082b8d91fc3b6535ce31eb8fa8228 commit e7bb1d51867082b8d91fc3b6535ce31eb8fa8228 Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Aug 02 13:43:34 2017 Disable flaky OmniBoxViewTests. BUG= 751543 TBR=pkasting@chromium.org Change-Id: I9e33b2f01f0c71bb7b032d16ec4e16443fadf0b2 Reviewed-on: https://chromium-review.googlesource.com/597853 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491359} [modify] https://crrev.com/e7bb1d51867082b8d91fc3b6535ce31eb8fa8228/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
,
Aug 2 2017
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1ccd58125c75660a7790724ea5faed78a055d0c commit e1ccd58125c75660a7790724ea5faed78a055d0c Author: Greg Thompson <grt@chromium.org> Date: Mon Dec 04 19:49:53 2017 Enable interactive_ui_tests on Windows that now run mostly reliably. r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG= 133341 ,751031, 751543 , 764415 , 789913 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: I753c741a9194f489f072cd86d72407a1294150c3 Reviewed-on: https://chromium-review.googlesource.com/784937 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521416} [modify] https://crrev.com/e1ccd58125c75660a7790724ea5faed78a055d0c/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ac914c0806c5885ef112f621b5ae62d13fdbf3 commit 16ac914c0806c5885ef112f621b5ae62d13fdbf3 Author: Greg Thompson <grt@chromium.org> Date: Tue Dec 05 10:24:50 2017 Revert "Enable interactive_ui_tests on Windows that now run mostly reliably." This reverts commit e1ccd58125c75660a7790724ea5faed78a055d0c. Reason for revert: Widespread "Check failed: false. Observers can only be added once!" failures. Original change's description: > Enable interactive_ui_tests on Windows that now run mostly reliably. > > r516772 was the last of many commits that resolved a number of problems > that made this test suite flaky on Windows. This CL enables tests that > had been disabled over time due to flakes, yet now seem to run okay. > > BUG= 133341 ,751031, 751543 , 764415 , 789913 > This CL was uploaded by git cl split. > > R=sky@chromium.org > > Change-Id: I753c741a9194f489f072cd86d72407a1294150c3 > Reviewed-on: https://chromium-review.googlesource.com/784937 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521416} TBR=sky@chromium.org,grt@chromium.org Change-Id: I33b192c628fdfebe9cfd93b71abd3b394faad9e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 133341 , 751031, 751543 , 764415 , 789913 Reviewed-on: https://chromium-review.googlesource.com/808204 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521652} [modify] https://crrev.com/16ac914c0806c5885ef112f621b5ae62d13fdbf3/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/660ca3f59534cde9e55e0e694dae6f028e262277 commit 660ca3f59534cde9e55e0e694dae6f028e262277 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Nov 13 19:56:31 2018 Re-enable disabled tests in chrome/browser/ui/omnibox/. These passed 50 times in a row on Windows. This converts from watching NOTIFICATION_NAV_ENTRY_COMMIT to using a navigation observer in hopes of fixing observed flakiness in EnterToSearch. Bug: 69433 , 133341 , 133344 , 133347 , 133355 , 133360 , 146953 , 408634 , 431575 , 751031, 751543 , 823532 , 841195 Change-Id: Ia8ce63c8a9aca1ea415fb99756b08409cbc8369c Reviewed-on: https://chromium-review.googlesource.com/c/1332257 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#607713} [modify] https://crrev.com/660ca3f59534cde9e55e0e694dae6f028e262277/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by guidou@chromium.org
, Aug 2 2017