New issue
Advanced search Search tips

Issue 751492 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

DownloadActivityTest#testSpaceDisplay flaky on Android Tests (dbg)

Project Member Reported by guidou@chromium.org, Aug 2 2017

Issue description

Sample failed runs:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44440
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44427

Log sample:

341d1344b9141)  preparing to run org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay: {'annotations': {'Restriction': {'value': ['Phone']}, 'MediumTest': None}, 'class': 'org.chromium.chrome.browser.download.DownloadActivityTest', 'is_junit4': False, 'method': 'testSpaceDisplay'}
I  258.946s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 logcat -c
I  259.009s run_tests_on_device(028341d1344b9141)  Opening text logdog stream, logcat_org.chromium.chrome.browser.download.DownloadActivityTest.testSpaceDisplay_20170801T124903-UTC_028341d1344b9141
I  259.010s record_to_stream  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 logcat -v threadtime '*:e' chromium:v 'cr_*:v' DEBUG:I StrictMode:D test_runner_py:I
I  259.010s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell '( log -p i -t test_runner_py '"'"'START org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay'"'"' );echo %$?'
I  259.074s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell '( ( p=org.chromium.chrome.tests;am instrument -w -r -e org.chromium.base.test.util.Screenshooter.ScreenshotDir /storage/emulated/legacy/chromium_tests_root/UiCapture -e class '"'"'org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay'"'"' -e org.chromium.base.test.ScreenshotOnFailureStatement.ScreenshotFile /storage/emulated/legacy/temp_file-c490ec959e8f.png "$p"/org.chromium.chrome.test.ChromeInstrumentationTestRunner )>/data/local/tmp/temp_file-9a1d53ffff3e9 2>&1 );echo %$?'
I  262.830s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 pull /data/local/tmp/temp_file-9a1d53ffff3e9 /b/swarming/w/itXWhbpH/tmp3JYsA9/tmp_ReadFileWithPull
I  262.906s TimeoutThread-1-for-delete_temporary_file(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell 'rm -f /data/local/tmp/temp_file-9a1d53ffff3e9'
I  262.908s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell '( log -p i -t test_runner_py '"'"'END org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay'"'"' );echo %$?'
I  262.987s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell '( rm -f /data/local/tmp/chrome_timeout_scale );echo %$?'
I  263.051s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell '( ( dumpsys window windows )>/data/local/tmp/temp_file-f717e43d7e3d4 2>&1 );echo %$?'
I  263.104s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 pull /data/local/tmp/temp_file-f717e43d7e3d4 /b/swarming/w/itXWhbpH/tmpZRgfKv/tmp_ReadFileWithPull
I  263.182s TimeoutThread-1-for-delete_temporary_file(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell 'rm -f /data/local/tmp/temp_file-f717e43d7e3d4'
I  263.183s TimeoutThread-1-for-run_tests_on_device(028341d1344b9141)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 028341d1344b9141 shell '( test -e /storage/emulated/legacy/temp_file-c490ec959e8f.png );echo %$?'
I  263.247s run_tests_on_device(028341d1344b9141)  detected failure in org.chromium.chrome.browser.download.DownloadActivityTest#testSpaceDisplay. raw output:
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: numtests=1
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: stream=
I  263.247s run_tests_on_device(028341d1344b9141)    org.chromium.chrome.browser.download.DownloadActivityTest:
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: test=testSpaceDisplay
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.download.DownloadActivityTest
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: current=1
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS_CODE: 1
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: numtests=1
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: stream=
I  263.247s run_tests_on_device(028341d1344b9141)    Failure in testSpaceDisplay:
I  263.247s run_tests_on_device(028341d1344b9141)    junit.framework.AssertionFailedError: expected:<512.00 MB downloaded> but was:<5.50 GB downloaded>
I  263.247s run_tests_on_device(028341d1344b9141)    	at org.chromium.chrome.browser.download.DownloadActivityTest.testSpaceDisplay(DownloadActivityTest.java:200)
I  263.247s run_tests_on_device(028341d1344b9141)    	at java.lang.reflect.Method.invokeNative(Native Method)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  263.247s run_tests_on_device(028341d1344b9141)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  263.247s run_tests_on_device(028341d1344b9141)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
I  263.247s run_tests_on_device(028341d1344b9141)    
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: id=InstrumentationTestRunner
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: test=testSpaceDisplay
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.download.DownloadActivityTest
I  263.247s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: stack=junit.framework.AssertionFailedError: expected:<512.00 MB downloaded> but was:<5.50 GB downloaded>
I  263.248s run_tests_on_device(028341d1344b9141)    	at org.chromium.chrome.browser.download.DownloadActivityTest.testSpaceDisplay(DownloadActivityTest.java:200)
I  263.248s run_tests_on_device(028341d1344b9141)    	at java.lang.reflect.Method.invokeNative(Native Method)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  263.248s run_tests_on_device(028341d1344b9141)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  263.248s run_tests_on_device(028341d1344b9141)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
I  263.248s run_tests_on_device(028341d1344b9141)    
I  263.248s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS: current=1
I  263.248s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_STATUS_CODE: -2
I  263.248s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_RESULT: stream=
I  263.248s run_tests_on_device(028341d1344b9141)    Test results for ChromeInstrumentationTestRunner=.F
I  263.248s run_tests_on_device(028341d1344b9141)    Time: 1.364
I  263.248s run_tests_on_device(028341d1344b9141)    
I  263.248s run_tests_on_device(028341d1344b9141)    FAILURES!!!
I  263.248s run_tests_on_device(028341d1344b9141)    Tests run: 1,  Failures: 1,  Errors: 0
I  263.248s run_tests_on_device(028341d1344b9141)    
I  263.248s run_tests_on_device(028341d1344b9141)    
I  263.248s run_tests_on_device(028341d1344b9141)    INSTRUMENTATION_CODE: -1
 
Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)
Added @RetryOnFailure.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2186d4cb42ccb77fd7990386e50f1d51dd478e06

commit 2186d4cb42ccb77fd7990386e50f1d51dd478e06
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Aug 02 12:13:25 2017

Add @RetryOnFailure to flaky DownloadActivityTest#testSpaceDisplay

BUG= 751492 
TBR=twellington@chromium.org

Change-Id: Ia823694259de8e88ac1f121fafcf9393b821472b
Reviewed-on: https://chromium-review.googlesource.com/597767
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491345}
[modify] https://crrev.com/2186d4cb42ccb77fd7990386e50f1d51dd478e06/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Cc: twelling...@chromium.org
Components: UI>Browser>Downloads
Labels: -Pri-2 OS-Android Pri-1
Owner: huayinz@chromium.org
This is likely more fall out from the DateDividedAdapter change.  huayinz@chromium.org will you please take a look?
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69cf190e88350c1555817fd62dc8a10886d8350

commit c69cf190e88350c1555817fd62dc8a10886d8350
Author: Becky Zhou <huayinz@chromium.org>
Date: Fri Aug 04 23:16:59 2017

Fix HistoryActivityTest and DownloadActivityTest#testSpaceDisplay

+ Set account to null and update privacy disclaimers in HistoryActivityTest#setUp()
+ Wait for onChanged callback twice to ensure space display is updated

Bug: 752520, 751492 
Change-Id: Idb2b59fe909039f3bce002b6cee8cf22f5ca2c18
Reviewed-on: https://chromium-review.googlesource.com/602571
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492167}
[modify] https://crrev.com/c69cf190e88350c1555817fd62dc8a10886d8350/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
[modify] https://crrev.com/c69cf190e88350c1555817fd62dc8a10886d8350/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java

Status: Fixed (was: Assigned)
I got a failure on a tryjob this morning, so I suspect this test is still flaky.


https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/356661

junit.framework.AssertionFailedError: expected:<512.00 MB downloaded> but was:<5.50 GB downloaded>
	at org.chromium.chrome.browser.download.DownloadActivityTest.testSpaceDisplay(DownloadActivityTest.java:206)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Status: Started (was: Fixed)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4105fc1f4f6aa74da7384fb689771c1d70d5d5ca

commit 4105fc1f4f6aa74da7384fb689771c1d70d5d5ca
Author: Becky Zhou <huayinz@chromium.org>
Date: Sat Aug 19 00:04:54 2017

Add RetryOnFailure to DownloadActivityTest#testSpaceDisplay

Bug:  751492 
Change-Id: I7774aad331c203ebba60605c76321be20759d98c
Reviewed-on: https://chromium-review.googlesource.com/622243
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495756}
[modify] https://crrev.com/4105fc1f4f6aa74da7384fb689771c1d70d5d5ca/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0fcece6fb5df4c1b222393b1dc45f6b2283d2f3

commit c0fcece6fb5df4c1b222393b1dc45f6b2283d2f3
Author: Becky Zhou <huayinz@chromium.org>
Date: Tue Nov 28 19:06:35 2017

Fix DownloadActivityTest#testSpaceDisplay

Changed Assert to Criteria checks for SpaceDisplay text updates.
Removed @RetryOnFailure flag.

Bug:  751492 
Change-Id: I04b2cfdbb058ed50daa0187ae95117801f4a5073
Reviewed-on: https://chromium-review.googlesource.com/792392
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519773}
[modify] https://crrev.com/c0fcece6fb5df4c1b222393b1dc45f6b2283d2f3/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Status: Fixed (was: Started)

Sign in to add a comment