Issue metadata
Sign in to add a comment
|
Text selection toolbar does not appear after tapping on 'Select All' option in "Pocket" app.
Reported by
pshi...@etouch.net,
Aug 2 2017
|
||||||||||||||||||||||
Issue descriptionDevice name: Pixel XL/N2G47O,Nexus 5X/N2G47O,Htc Desire 630/MMB29M,Samsung Galaxy J5/MMB29M,Samsung Galaxy J2/LMY47X WebView version: 62.0.3174.0 Application: Pocket Application version: 6.5.9.6 Application package:com.ideashower.readitlater.pro Bisect Information: Per-Version bisect information: Good build: 57.0.2984.0 Bad build: 57.0.2985.0 Regression range: https://chromium.googlesource.com/chromium/src/+log/57.0.2984.0..57.0.2985.0?pretty=fuller&n=10000 Steps to reproduce: (1)Launch 'Pocket' app,sign in with valid credentials (2)Open any article,Long tap for text selection and tap on select all (3)Observe Actual result: Text selection toolbar does not appear after tapping on 'Select All' option. Expected result: Text selection toolbar should appear properly after tapping on 'Select All' option. Additional comment: This issue is also reproducible on playstore version: 59.0.3071.125
,
Aug 2 2017
Per-CL bisect information: Good commit:444118 Bad commit:444119 C 734.174s Main You are looking for a change made after 444118(GOOD), but before 444119(BAD). Suspect CL: https://chromium.googlesource.com/chromium/src/+/1107a295dcee2f4ee3f6c24f836c6adfa7b3830d amaralp@ Might be it looks like this issue is related to your change. please look into once, if its not related to your change please reassign to me. Thansk!
,
Sep 14 2017
Issue still repro on latest M62: 62.0.3202.23 & M63: 63.0.3215.0 hence moving to M63. Thanks!
,
Nov 27 2017
It looks like Pocket overrode the action mode and used a custom implementation of select all that doesn't ever lead to a call to FrameSelection::SelectAll(). Is there a way we could ask them how they are implementing SelectAll?
,
Nov 28 2017
satyavathir@Could you please look into issue. Thanks!
,
Dec 20 2017
we are able to repro this issue on latest M64: 64.0.3282.41 & M65: 65.0.3299.3, as M63 gone to stable moving to M65 Thanks!
,
Dec 20 2017
,
Dec 21 2017
As c#4 said, we need to contact developer of com.ideashower.readitlater.pro to know how they are implementing Select All. They probably did something to the selection popup because there is a custom menu item "Recommend". After "Select All", if we click anywhere in that page, selection menu will show again anyway. Lower the priority since this happens with M57. And I think this is more of app bug other than WebView bug. Open this bug to public so we could have better communication with the app developer.
,
Jan 12 2018
,
Jan 12 2018
After talking to developers from Pocket, amaralp@ suggested the way for customizing select all in JavaScript is:
document.execCommand("selectAll");
I am closing this issue as there is no fix from WebView side.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by battun@chromium.org
, Aug 2 2017Status: Untriaged (was: Unconfirmed)