Issue metadata
Sign in to add a comment
|
Some mac*_blink_rel trybots fail in the analyze step |
||||||||||||||||||||||
Issue descriptionFrom https://chromium-review.googlesource.com/c/597222 (patchset 1) for example: - https://luci-milo.appspot.com/buildbot/tryserver.blink/mac10.9_blink_rel/3332 - https://luci-milo.appspot.com/buildbot/tryserver.blink/mac10.10_blink_rel/3307 - https://luci-milo.appspot.com/buildbot/tryserver.blink/mac10.11_retina_blink_rel/3357 /b/c/b/mac_layout/src/buildtools/mac/gn gen //out/Release --check -> returned 1 ERROR at //build/config/mac/mac_sdk.gni:55:5: Script returned non-zero exit code. exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines") ^---------- Current dir: /b/c/b/mac_layout/src/out/Release/ Command: python -- /b/c/b/mac_layout/src/build/mac/find_sdk.py --print_sdk_path 10.12 Returned 1. stderr: Traceback (most recent call last): File "/b/c/b/mac_layout/src/build/mac/find_sdk.py", line 89, in <module> print main() File "/b/c/b/mac_layout/src/build/mac/find_sdk.py", line 62, in main raise Exception('No %s+ SDK found' % min_sdk_version) Exception: No 10.12+ SDK found See //build/config/sysroot.gni:74:3: whence it was imported. import("//build/config/mac/mac_sdk.gni") ^-------------------------------------- See //base/BUILD.gn:28:1: whence it was imported. import("//build/config/sysroot.gni") ^---------------------------------- See //BUILD.gn:72:5: which caused the file to be included. "//base:base_unittests", ^---------------------- GN gen failed: 1 I believe this is caused by https://chromium-review.googlesource.com/570459 ("Bump macOS SDK to 10.12") and bug 669240 .
,
Aug 2 2017
,
Aug 2 2017
This is preventing baseline generation and holding up my work for the following bots, with examples: https://build.chromium.org/p/tryserver.blink/builders/mac10.9_blink_rel/builds/3338 https://build.chromium.org/p/tryserver.blink/builders/mac10.11_blink_rel/builds/3433 https://build.chromium.org/p/tryserver.blink/builders/mac10.10_blink_rel/builds/3313 https://build.chromium.org/p/tryserver.blink/builders/mac10.11_retina_blink_rel/builds/3362 The mac10.11_retina_blink_rel seems flaky in that it failed once then ran again. The others have failed twice in a row.
,
Aug 2 2017
Yep, the first failure on all of those bots (e.g. https://build.chromium.org/p/tryserver.blink/builders/mac10.9_blink_rel?numbuilds=100) is immediately after erikchen@'s sdk update landed. I'm going to revert that sdk update, but going to chat him first to make sure that's safe. If he doesn't respond in 5 minutes I'm just gonna do it.
,
Aug 2 2017
Part of the problem is that those bots aren't yet running the layout_tests via swarming, and hence they're still building on 10.9/10.10/10.11, and I think the sdk bump requires 10.12 builders. We really need to finish upgrading all of the bots to swarm those tests.
,
Aug 2 2017
Revert is in CQ: https://chromium-review.googlesource.com/c/598449
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00068b7e6365c9ac4994e8f3ee94b8c8a275ab5a commit 00068b7e6365c9ac4994e8f3ee94b8c8a275ab5a Author: Aaron Gable <agable@chromium.org> Date: Wed Aug 02 17:01:52 2017 Revert "Bump macOS SDK to 10.12." This reverts commit f5345de13668f0176b11126a7ae391dad5b4ad0f. Reason for revert: Breaks bots which run layout_tests not via swarming: https://crbug.com/751421 Original change's description: > Bump macOS SDK to 10.12. > > Bug: 669240 > Change-Id: I97cf582b97fac7aec2aa92bbdda02f5c17482c1d > Reviewed-on: https://chromium-review.googlesource.com/570459 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491060} TBR=thakis@chromium.org,erikchen@chromium.org Change-Id: I3b30bd3e18fa60f736078ed889a6c574b15c6467 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669240 , 751421 Reviewed-on: https://chromium-review.googlesource.com/598449 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#491408} [modify] https://crrev.com/00068b7e6365c9ac4994e8f3ee94b8c8a275ab5a/build/config/mac/mac_sdk_overrides.gni [modify] https://crrev.com/00068b7e6365c9ac4994e8f3ee94b8c8a275ab5a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
,
Aug 2 2017
We have a successful analyze step on the next build: https://build.chromium.org/p/tryserver.blink/builders/mac10.9_blink_rel/builds/3340/steps/analyze |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by drott@chromium.org
, Aug 2 2017