Issue metadata
Sign in to add a comment
|
Regression: Allow/ Block button of permission bubble is not seen properly.
Reported by
db...@etouch.net,
Aug 2 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:62.0.3174.0 (Official Build) 02ca96925ccb743e83ad34bee8595e4a6eec8443-refs/heads/master@{#491203}(64-bit) OS: Mac(10.11.6 ) What steps will reproduce the problem? (1) Launch chrome, navigate to https://permission.site/ (2) Click on 'Location', observe Allow/ Block button on bubble. Actual: Allow/ Block button of bubble is not seen properly i.e. seen in Bold letters. Expected: Allow/ Block button of bubble should seen properly. This is Regression issue broken in M-62 and will soon update other bisect info. Manual Bisect Info: Good Build: 62.0.3166.0 Bad Build: 62.0.3168.0 Note: Issue is not seen on Windows, Linux and Mac(10.12, 10.12.3)
,
Aug 2 2017
Yeah! nice bug. This will be r489245. The problem is that Apple didn't ship a MEDIUM-weight system font on 10.11. So, when we ask for MEDIUM, we get bold. There's some foreshadowing about this in http://crbug.com/691891#c20 . And we've already discussed with designers. Plan is to just make this a NORMAL weight on 10.11 rather than MEDIUM.
,
Aug 2 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d538b1be07308865bc4b6e2d6bc2103017f2859 commit 4d538b1be07308865bc4b6e2d6bc2103017f2859 Author: Trent Apted <tapted@chromium.org> Date: Fri Aug 04 06:53:52 2017 Make button fonts NORMAL weight on macOS 10.11 and 10.9. Apple doesn't ship a MEDIUM weight font in 10.11 or 10.9. The font system will upgrade it to BOLD (this is covered by tests in platform_font_mac_unittests.mm). BOLD is too bold for buttons in UI, so use a NORMAL weight. Bug: 751414 Change-Id: I5dbac5a165120c919a92476f9fce6747c7e733c1 Reviewed-on: https://chromium-review.googlesource.com/597511 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#491955} [modify] https://crrev.com/4d538b1be07308865bc4b6e2d6bc2103017f2859/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/4d538b1be07308865bc4b6e2d6bc2103017f2859/ui/views/style/typography_provider.cc [modify] https://crrev.com/4d538b1be07308865bc4b6e2d6bc2103017f2859/ui/views/style/typography_provider.h
,
Aug 4 2017
,
Aug 8 2017
Just to update: Above issue is fixed on latest dev 62.0.3178.0
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by benwells@chromium.org
, Aug 2 2017