New issue
Advanced search Search tips

Issue 751413 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Project Member Reported by horo@chromium.org, Aug 2 2017

Issue description

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Builders failed on: 
- WebKit Linux Trusty Leak: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak


Unexpected Failures:
* external/wpt/webaudio/the-audio-api/the-waveshapernode-interface/curve-tests.html
* webaudio/Analyser/handle-silent-inputs.html
* webaudio/Analyser/realtimeanalyser-downmix.html
* webaudio/Analyser/realtimeanalyser-float-data.html
* webaudio/AudioNode/audionode-connect-method-chaining.html
* webaudio/AudioNode/tail-processing.html
* webaudio/AudioParam/audioparam-k-rate.html
* webaudio/AudioParam/audioparam-nominal-range.html
* webaudio/BiquadFilter/biquad-automation.html
* webaudio/BiquadFilter/tail-time-highpass.html
* webaudio/BiquadFilter/tail-time-lowpass.html
* webaudio/BiquadFilter/tail-time-notch.html
* webaudio/Delay/delaynode-maxdelay.html
* webaudio/Delay/delaynode-maxdelaylimit.html
* webaudio/IIRFilter/iirfilter.html
* webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html
* webaudio/OfflineAudioContext/onstatechange.html
* webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html
* webaudio/dom-exceptions.html
* webaudio/internals/offlineaudiocontext-detached-no-crash.html

 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b867aebfeb296c45e4004f7977bf1c845cab54

commit c9b867aebfeb296c45e4004f7977bf1c845cab54
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Aug 02 07:18:41 2017

Revert "Implement tail processing for AudioNodes"

This reverts commit f643128b41b9ea11a583fa255b7df3c73cab2c37.

Reason for revert: leaks in LayoutTests

BUG: 751413

Original change's description:
> Implement tail processing for AudioNodes
> 
> Keep nodes alive when there are no input connections so that the node
> has time to flush out any internal memory. When the output of the node
> is going to be disabled (because there are no inputs), place the node
> on a list, without disabling the output.
> 
> The list is processed every rendering quantum to see if the tail time
> of node has passed.  If the tail time has not passed, nothing is done;
> otherwise, the output is disabled, and the node is removed from the
> list.  This allows the node to be collected, if possible.
> 
> Bug:357843 
> Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html,
> internals/cycle-connection-gc.html
> 
> Change-Id: Iab28ec749ee532cbb2ee9631501a6dac0ceb0afb
> Reviewed-on: https://chromium-review.googlesource.com/583587
> Reviewed-by: Hongchan Choi <hongchan@chromium.org>
> Commit-Queue: Hongchan Choi <hongchan@chromium.org>
> Commit-Queue: Raymond Toy <rtoy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491135}

TBR=rtoy@chromium.org,hongchan@chromium.org

Change-Id: I3201106063305b9ec6892508823ab1f665a56fba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  357843 
Reviewed-on: https://chromium-review.googlesource.com/597609
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491292}
[delete] https://crrev.com/46aa62e5105c266de03f0527f6bff506e424b56b/third_party/WebKit/LayoutTests/webaudio/AudioNode/tail-processing.html
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/LayoutTests/webaudio/internals/cycle-connection-gc.html
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/LayoutTests/webaudio/resources/note-grain-on-testing.js
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AnalyserNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/GainNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/PannerNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/AudioDSPKernel.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/AudioProcessor.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/DynamicsCompressor.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/EqualPowerPanner.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/HRTFPanner.cpp
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/HRTFPanner.h
[modify] https://crrev.com/c9b867aebfeb296c45e4004f7977bf1c845cab54/third_party/WebKit/Source/platform/audio/Panner.h

Labels: -Sheriff-Chromium

Comment 5 by rtoy@chromium.org, Aug 10 2017

That's weird. The offending CL was reverted so tail-time-lowshelf.html shouldn't have changed.

Comment 6 by rtoy@chromium.org, Sep 11 2017

Components: Blink>WebAudio
external/wpt/dom/traversal/NodeIterator-removal.html

This is not even a WebAudio test.
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment