New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751407 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

content_browsertests failing on 2 builders

Project Member Reported by horo@chromium.org, Aug 2 2017

Issue description

content_browsertests failing on 2 builders

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests
- Linux MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests



==1:1==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x12268aa0 in blink::LayoutTableCell::ShouldClipOverflow() const third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:459:35
    #1 0x12ac5959 in NeedsOverflowClip third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:803:48
    #2 0x12ac5959 in UpdatePaintProperties third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1208:0
    #3 0x12ac5959 in blink::PaintPropertyTreeBuilder::UpdatePropertiesForSelf(blink::LayoutObject const&, blink::PaintPropertyTreeBuilderContext&) third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:1244:0
    #4 0x12a5f91d in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:190:28
    #5 0x12a60418 in blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp:215:5




 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25f768cdadae5ad6462136dac42a411fa4be103

commit b25f768cdadae5ad6462136dac42a411fa4be103
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Aug 02 07:27:18 2017

Initialize LayoutTableCell.is_spanning_collapsed_row_ to avoid MSAN error

TBR: joysyu@google.com
Bug:  751407 
Change-Id: I3bb805d6f6c2a555925ce3ccf514e1e4b2d8df0a
Reviewed-on: https://chromium-review.googlesource.com/597031
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491295}
[modify] https://crrev.com/b25f768cdadae5ad6462136dac42a411fa4be103/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a948ec8379c9d294676044731a94288042bbd08

commit 7a948ec8379c9d294676044731a94288042bbd08
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Aug 02 09:03:23 2017

Revert "Initialize LayoutTableCell.is_spanning_collapsed_row_ to avoid MSAN error"

This reverts commit b25f768cdadae5ad6462136dac42a411fa4be103.

Reason for revert: Caused compile error.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac_Builder__dbg_%2F209280%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

../../third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:63:7: error: member initializer 'is_spanning_collapsed_row_' does not name a non-static data member or base class
      is_spanning_collapsed_row_(false),
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> Initialize LayoutTableCell.is_spanning_collapsed_row_ to avoid MSAN error
> 
> TBR: joysyu@google.com
> Bug:  751407 
> Change-Id: I3bb805d6f6c2a555925ce3ccf514e1e4b2d8df0a
> Reviewed-on: https://chromium-review.googlesource.com/597031
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491295}

TBR=horo@chromium.org,joysyu@google.com

Change-Id: Ice425494d4c1de47a48497636401616d9fe6cc89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  751407 
Reviewed-on: https://chromium-review.googlesource.com/597093
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491318}
[modify] https://crrev.com/7a948ec8379c9d294676044731a94288042bbd08/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d3a6f1cd01ac1375f275623e48e1c890532ad2c

commit 0d3a6f1cd01ac1375f275623e48e1c890532ad2c
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Aug 02 09:28:03 2017

Revert "Revert "Initialize LayoutTableCell.is_spanning_collapsed_row_ to avoid MSAN error""

This reverts commit 7a948ec8379c9d294676044731a94288042bbd08.

Reason for revert: This fix was reverted because the CL it fixes was reverted. The original CL has been relanded and now the fix should work.


Original change's description:
> Revert "Initialize LayoutTableCell.is_spanning_collapsed_row_ to avoid MSAN error"
> 
> This reverts commit b25f768cdadae5ad6462136dac42a411fa4be103.
> 
> Reason for revert: Caused compile error.
> 
> https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac_Builder__dbg_%2F209280%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
> 
> ../../third_party/WebKit/Source/core/layout/LayoutTableCell.cpp:63:7: error: member initializer 'is_spanning_collapsed_row_' does not name a non-static data member or base class
>       is_spanning_collapsed_row_(false),
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> 
> Original change's description:
> > Initialize LayoutTableCell.is_spanning_collapsed_row_ to avoid MSAN error
> > 
> > TBR: joysyu@google.com
> > Bug:  751407 
> > Change-Id: I3bb805d6f6c2a555925ce3ccf514e1e4b2d8df0a
> > Reviewed-on: https://chromium-review.googlesource.com/597031
> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#491295}
> 
> TBR=horo@chromium.org,joysyu@google.com
> 
> Change-Id: Ice425494d4c1de47a48497636401616d9fe6cc89
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  751407 
> Reviewed-on: https://chromium-review.googlesource.com/597093
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491318}

TBR=horo@chromium.org,joysyu@google.com

Change-Id: Ic130312825f08f443d5f3bf5fbddac556607d4aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  751407 
Reviewed-on: https://chromium-review.googlesource.com/597707
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491323}
[modify] https://crrev.com/0d3a6f1cd01ac1375f275623e48e1c890532ad2c/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Status: Fixed (was: Available)
I believe this is fixed by horo@'s CL.
Please reopen if this is not the case.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5c9aa19624d4de356f688b677865fd1aa00ad0f

commit b5c9aa19624d4de356f688b677865fd1aa00ad0f
Author: David Reveman <reveman@chromium.org>
Date: Sat Nov 04 02:03:03 2017

exo: Improve XDG shell implementation.

This adds proper objects for toplevel and popups so we can
guarantee correct tear down of resources and not depend on
xdg surface resources to outlive toplevel/popup resources.

Bug:  751407 
Change-Id: I2fe6c94f6b953aae3a27e4c5fb2ad5590feeed61
Reviewed-on: https://chromium-review.googlesource.com/753822
Commit-Queue: David Reveman <reveman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514012}
[modify] https://crrev.com/b5c9aa19624d4de356f688b677865fd1aa00ad0f/components/exo/wayland/server.cc

Sign in to add a comment