In NTP page ‘Rate this app’ promo text is displayed in incorrect location, when content suggestions are displayed |
|||||
Issue descriptionApp Version: 62.0.3173.0 iOS Version: 9.3.5, 10.3.3, 11.0 beta4 Device: iPhone and iPad Pre-requisite: 1. Enable App rating promo from experimental settings 2. Enable chrome suggestions UI Steps to reproduce: 1. Launch chrome in portrait 2. Change the device orientation to landscape Observed results: 1. In iPad the position of the ‘Rate this app’ text is displayed to left in both portrait and landscape 2. In iPhone the position of the ‘Rate this app’ text is displayed to left in landscape Expected results: Chrome promo should appear in middle of the NTP and below the fake omnibox. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M60 Bug reproducible on the current beta channel build (App Version, iOS Version): No on 61.0.3163.25 (New feature) Link to video/image: iPad Screenshot: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8RzBFX3hkZEhzNkk/view?usp=sharing iPhone Screenshot: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8LVVGMkJJTE9CV1k/view?usp=sharing
,
Aug 2 2017
gambard@ PTAL.
,
Aug 3 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2 commit c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2 Author: gambard <gambard@chromium.org> Date: Fri Aug 04 14:39:12 2017 Fix What's New promo centering The promo wasn't centered because the header needs to take the whole width whereas the promo has a smaller width. Putting the promo in its own section allows the view controller to SectionInset for this section, allowing the promo to be centered. Bug: 751402 Change-Id: I1947deee9e2304174731b933ea3e79bfd094d014 Reviewed-on: https://chromium-review.googlesource.com/600187 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#492025} [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/content_suggestions/mediator_util.h [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/content_suggestions/mediator_util.mm [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_whats_new_item.mm [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h [modify] https://crrev.com/c2fbb0a8c0babbecd1594ff4917ca0c42694d8c2/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm
,
Aug 4 2017
,
Aug 8 2017
Verified on chrome canary version 62.0.3179.0 on iPhone 6s/iOS 10.3.2 and iPad Air/iOS 10.3.3 following the steps mentioned in comment #0. "Rate this app" promo is displayed at the correct location in both landscape and portrait orientation. Looks good. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mvanouwe...@chromium.org
, Aug 2 2017