Issue metadata
Sign in to add a comment
|
chrome://net-export is duplicated
Reported by
pierre.n...@gmail.com,
Aug 2 2017
|
||||||||||||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Open Chrome on Android device and run: chrome://about 2. Scroll to chrome://net-export What is the expected behavior? What went wrong? chrome://net-export is duplicated Did this work before? N/A Chrome version: 60.0.3112.78 Channel: stable OS Version: 59.0.3071.125 Flash Version:
,
Aug 2 2017
Thanks for the report. Must be specific to Android, as I cannot reproduce on Desktop.
,
Aug 2 2017
,
Aug 2 2017
,
Aug 2 2017
From that screenshot looks like chrome://network-errors is duplicated too.
,
Aug 2 2017
RE comment #5: Oh I just misread: one is network-errors the other network-error :)
,
Aug 2 2017
Yes, but, I created a pull request but I do not know how to add it here https://chromium-review.googlesource.com/c/596988 So.. can you review it?
,
Aug 2 2017
Sure, I will review your change than, and abandon the one I posted (https://chromium-review.googlesource.com/c/598503).
,
Aug 2 2017
Thank you so much. And one more, I think my upload have a prefix [WIP] in title. Should everyone do not review it. It seems a bit difficult for me to start, the docs does not mention the status of the pull request and I do not know how to clear this WIP status.
,
Aug 2 2017
The normal process is to upload the CL, and once you are ready to have it reviewed click the red "Start Review" button. Next enter an email address in the "Reviewers" field and click the blue "Start review" button. Only once you have submitted the review in this fashion will the reviewer be notified by email (this is why I didn't know about your change list). Finding the right reviewer is not always trivial. Looking at file history, component owners, or filing a bug can help narrow things down. (There isn't a central queue for incoming reviews, so you do need to try and guess a reviewer first). Cheers.
,
Aug 3 2017
Providing more information for the issue. Tested the issue on Latest Stable# 59.0.3071.125 on Samsung J710 (Android 6.0.1) and was able to reproduce the issue. This is a Regression in M56 and below is the regression range -- Chrome Good Build -- 56.0.2894.0 (Revision: 425838). Chrome Bad Build -- 56.0.2895.0 (Revision: 426105). Good Commit -- 426079. Bad Commit -- 426080. Culprit CL -- https://chromium.googlesource.com/chromium/src/+/288fad6d153b251fe1360f76b15c718290aa2b43 Adding the related owner in Cc as already another Dev is working on the issue.
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d17a904c60cfd5b28ce48fab86dc23678bfa871 commit 9d17a904c60cfd5b28ce48fab86dc23678bfa871 Author: Pierre Neter <pierreneter@gmail.com> Date: Thu Aug 03 19:04:11 2017 remove duplicate of chrome://net-export in chrome://about Signed-off-by: Pierre Neter <pierreneter@gmail.com> Bug: 751391 Change-Id: I6b2d4d1102f2424cff411147637bae6c31c1acd0 Reviewed-on: https://chromium-review.googlesource.com/596988 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491810} [modify] https://crrev.com/9d17a904c60cfd5b28ce48fab86dc23678bfa871/AUTHORS [modify] https://crrev.com/9d17a904c60cfd5b28ce48fab86dc23678bfa871/chrome/common/url_constants.cc
,
Aug 29 2017
,
Aug 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsgav...@chromium.org
, Aug 2 2017