New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751390 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Notification icon in the shelf not showing off/silent mode

Reported by thomas.l...@gmail.com, Aug 2 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9460.73.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.134 Safari/537.36
Platform: 9460.73.0 (Official Build) stable-channel swanky

Steps to reproduce the problem:
Click the notification icon in the shelf and set it in off/silent mode. The notification icon shows the little bell unless there are any notifications, then it shows the number of notifications. When you click the bell you are able to set it in OFF/silent mode. This is not reflected in the icon in the shelf.

What is the expected behavior?
I would like the icon in the shelf to behave like this.
- Show the bell in standard mode (notifications ON)
- Show the number of notifications when notifications
- Show the bell with the / in off/silent mode (notification OFF)

Should be like the speaker icon when speaker is set to OFF

What went wrong?
Notification icon in the shelf not showing off/silent mode

Did this work before? No 

Chrome version: 59.0.3071.134  Channel: stable
OS Version: 9460.73.0
Flash Version: 26.0.0.137 /run/imageloader/PepperFlashPlayer/libpepflashplayer.
 
Screenshot 2017-08-02 at 073945.jpg
14.4 KB View Download
Components: -UI UI>Shell>Notifications
Owner: yoshiki@chromium.org
Status: Assigned (was: Unconfirmed)
Please confirm with UX/PM to see whether it is WAI. 
Cc: yoshiki@chromium.org
Owner: sgabr...@chromium.org
Sebastien, do you think this idea?

I think notifying silent-mode is good. But I think the bell icon is not good for this, since it is shown only when there are no notifications.
Quick behavior question before I answer.
If I activate do not disturb, will notification icon still stack-up in the status tray? replacing the bell icon?
Cc: tetsui@chromium.org
Adding tetsui@ since he recently worked around here.

Re c#4:
The answer is the icons from the notifications will remain. Even when user activates do not disturb, the behavior of the status bar will not be changed. Do-not-disturb is the feature just suppressing popups.
Thanks a lot. This is a good suggestion.
Let's replace the bell in the status area with the Do not disturb icon attached when the user enables it. Behavior remains the same as with the bell.

General spec has been updated as well:
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZYhMpwexg3v6/files/MCFZDbLqO8PAMMIlwn2nK06iwMSJbxAVNpw



Do not disturb icon.zip
1.9 KB Download
spec excerpt.png
133 KB View Download
Cc: -yoshiki@chromium.org sgabr...@chromium.org
Owner: yoshiki@chromium.org

Comment 8 by tetsui@chromium.org, Nov 14 2017

Cc: -tetsui@chromium.org yoshiki@chromium.org
Owner: tetsui@chromium.org
Status: Started (was: Assigned)
I would take this item. Thank you!
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32991b329801d22a0dfca99844d267475f20d193

commit 32991b329801d22a0dfca99844d267475f20d193
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Nov 16 00:53:31 2017

Replace shelf bell icon when do-not-disturb mode is on.

When there is no notification, the bell icon is shown on the shelf.
When you enable do-not-disturb mode from the notification center, it
should also change the bell icon icon on the shelf as well.

Mock:  https://crbug.com/751390#c6 

TEST=manual
BUG= 751390 

Change-Id: I6f537ba0ca02e1e6bbf93683d64ed932f47e4af9
Reviewed-on: https://chromium-review.googlesource.com/767620
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516928}
[modify] https://crrev.com/32991b329801d22a0dfca99844d267475f20d193/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/32991b329801d22a0dfca99844d267475f20d193/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/32991b329801d22a0dfca99844d267475f20d193/ash/system/web_notification/web_notification_tray_unittest.cc

Status: Fixed (was: Started)

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 12 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment