New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751384 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted 'code syntax' is observed in error message dialog.

Reported by avsha...@etouch.net, Aug 2 2017

Issue description

Chrome version : 62.0.3174.0 (Official Build) 02ca96925ccb743e83ad34bee8595e4a6eec8443-refs/heads/master@{#491203} 64 bit
OS : Windows (7,8,10)

Test URL : 
1. http://che.org.il/wp-content/uploads/2016/12/pdf-sample.pdf

What steps will reproduce the problem?
1. Launch chrome, navigate to above Test URL, right click on PDF and select 'Inspect' option (devtools window opens).
2. Hit F5 key, close devtools and observe error message on PDF file. 

Actual Result : Unwanted code syntax is observed in error message dialog.

Expected Result : Code syntax should not be seen in error message dialog.

This is a regression issue broken in ‘M-62’, will soon update Manual Regression range.
 
Actual_Result.mp4
820 KB View Download
Labels: OS-Linux
Manual regression range :
Good build : 62.0.3173.0
Bad build : 62.0.3174.0

Note : Issue is also seen on Linux(14.04 LTS) OS in latest canary build #62.0.3174.0 and will update Mac info once build is available.
Labels: OS-Mac
Update : 
Issue is also reproducible on Mac(10.12.3, 10.12.5, 10.11.6) OS with build #62.0.3174.0.
Expected_Result.mp4
704 KB View Download
Cc: jmukthavaram@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable Needs-Triage-M62
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7 , mac 10.12.4 & Ubuntu 14.04 using chrome latest Canary-62.0.3174.0.
Manual bisect info:
------------------
Good build : 62.0.3172.0- Revision-490684
Bad build : 62.0.3174.0 - Revision-491203

Per revision bisect info:
--------------------------
You are probably looking for a change made after 491094 (known good), but no later than 491095 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/d9622b4242a2deffde74318e6ee5a3b73f2a8fb8..81c6fb8cfb6514216cac0107767e35884573a59b

Possible suspect:
----------------
https://chromium.googlesource.com/chromium/src/+/81c6fb8cfb6514216cac0107767e35884573a59b

dschuyler@, Could you please take a look and reassign the right owner if it is not related to your change.

Since it is regressed recently, adding Release block stable' label . Please remove if it is not required.

Thanks..!!
Status: Started (was: Assigned)
CL at hhttps://chromium-review.googlesource.com/c/599069
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b76712be975e258bbfc4ea62e6e2740064cc8f18

commit b76712be975e258bbfc4ea62e6e2740064cc8f18
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Aug 03 01:30:45 2017

[html] fix missing or extraneous lt/gt in html

This CL fixes an extraneous gt (>) causing an error message to display
improperly. Also fixed a missing lt (<) in my search to see if the gt
mistake had been made elsewhere.

Bug:  751384 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I808aa2e811e72f39e781aa7232fd798514ef8f73
Reviewed-on: https://chromium-review.googlesource.com/599069
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491597}
[modify] https://crrev.com/b76712be975e258bbfc4ea62e6e2740064cc8f18/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/b76712be975e258bbfc4ea62e6e2740064cc8f18/chrome/browser/resources/settings/internet_page/network_proxy.html

Labels: -Needs-Triage-M62
Status: Fixed (was: Started)
Labels: TE-Verified-M62 TE-Verified-62.0.3178.0
Retested above issue in latest chrome #62.0.3178.0 build on Windows(7,8,10), Mac(10.12.3, 10.12.5, 10.11.6)& Linux(14.04 LTS) OS and issue is fixed now. After reloading, error message dialog is seen without any 'code syntax' and it is working as intended.

Thank you..
Dev_Behaviour.mp4
1.1 MB View Download

Sign in to add a comment