New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751382 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Custom wallpaper disappears after locking device

Project Member Reported by zelidrag@chromium.org, Aug 2 2017

Issue description

Chrome Version       : 61.0.3163.13
OS Version: 9765.7.0

What steps will reproduce the problem?
1. Set a custom wallpaper
2. Lock the device with [Search]+L

What is the expected result?

Custom wallpaper is shown on the lock screen as well.

What happens instead of that?

Custom wallpaper gets replaced with the default one. It reappears on logout+login again.



Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9765.7.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.13 Safari/537.36



 
Cc: r...@chromium.org jdufault@chromium.org x...@chromium.org
Owner: wzang@chromium.org
Most likely caused by wallpaper refactors.

Comment 2 by wzang@chromium.org, Aug 7 2017

Labels: Restrict-View-Google
Status: WontFix (was: Assigned)
Not reproducible on 61.0.3163.13, on Eve or Samus device. Please feel free to reopen.
Labels: -Restrict-View-Google
I'll see if I can reproduce this tomorrow, as I've seen it a number of times as well.
Status: Assigned (was: WontFix)
I can 100% reliably repro this on 61.0.3163.30 (Caroline). Happy to show it to you.


...btw, I have a custom wallpaper here, not one of defaults.

Comment 6 by wzang@chromium.org, Aug 8 2017

Cc: -x...@chromium.org wzang@chromium.org bshe@chromium.org
Owner: x...@chromium.org
I confirm this is not related to wallpaper refactoring as none of the codes were landed in 61.0.3163.30. Assigning to Daisy who knows much more about wallpaper and I'm happy to assist.

So the issue is reproducible at least in 61.0.3163.30 (Caroline), and I double checked that it is not reproducible in 61.0.3163.13 or 61.0.3163.30 (Eve or Samus), using a custom wallpaper. This suggests this issue may be device specific, along with another device-specific wallpaper issue crbug.com/751314.

Comment 7 by x...@chromium.org, Aug 8 2017

I could not recall any recent wallpaper changes. Will try to test it later today.

Comment 8 by x...@chromium.org, Aug 9 2017

I could not repro this on my caroline on 62.0.3179.0 (Platform 9798.0.0) and also on exactly 61.0.3163.30. Anyone else can repro this issue? I doubt this is a device specific issue as we don't handle any board specially.

Zel, what kind of account you were using? corp account? regular account? Or other account? Is your device managed device? 
I am on @google.com account. I will test @gmail.com...

Comment 10 by x...@chromium.org, Aug 9 2017

Tested my google.com account on the same Chrome version (61.0.3163.30) but still have no luck to repro it. 

Comment 11 by x...@chromium.org, Aug 9 2017

I could not repro this issue, though I noticed another interesting issue that might be related to the login screen overlay. During testing, I set a colorful custom wallpaper and then lock the screen using Search+L, as seen in the screenshots, the login screen is dimmed and blurred and looks like it's using a totally different wallpaper. Is this possible that the issue seen here is just the wallpaper was blurred too much?
Screenshot 2017-08-09 at 3.46.45 PM.png
5.6 MB View Download
Screenshot 2017-08-09 at 3.47.00 PM.png
1.0 MB View Download
I tested this wallpaper and this is intended... the blur amount is 30px specified by UX. The dimming color is also intended. The actual screen look slightly brighter than what the screenshot shows after comparing my screen and the screenshot I took.
I've dug our more details from my logs:

[6593:10512:0810/150318.384328:ERROR:wallpaper_manager_base.cc(599)] Failed to load custom wallpaper from its original fallback file path: /home/chronos/custom_wallpapers/original/c0eb6d9137d765b4bd4430dc2a4a3b4bdf9da16b/1501536873456

[6593:10512:0810/150318.384433:ERROR:wallpaper_manager_base.cc(608)] Failed to load previously selected custom wallpaper. Fallback to default wallpaper. Expected wallpaper path: /home/chronos/custom_wallpapers/large/c0eb6d9137d765b4bd4430dc2a4a3b4bdf9da16b/1501536873456

Comment 14 by x...@chromium.org, Aug 12 2017

Cc: xiy...@chromium.org
Still have no idea. I looked through the code and it does seem like it has code path that we load a default wallpaper on the lock screen if the custom wallpaper could not be found or loaded. But it could not explain why you can get it back after logout/login back. Does it happen for the regular account?
+xiyuan for thoughts

Comment 15 by x...@chromium.org, Aug 17 2017

I found a use case that might explain the behavior here. Steps:
- Have two users A and B with their custom wallpapers on the device
- Log in user A, manually remove its custom wallpaper from /home/chronos/custom_wallpapers from the developer console (to simulate the error seen in #13)
- Log out user A
- Log in user B
- Lock the screen

Instead of showing B's custom wallpaper, it shows the default wallpaper. The reason is that we try to cache all user's wallpapers in lock/login screen, and if we can't find one user's custom wallpaper, we fall back to set the default wallpaper directly. We should just cache the default wallpaper in this case.

Comment 16 by bshe@chromium.org, Aug 18 2017

It might be related to the wallpaper itself. During logged in session, we use a unsafe png decoder. But at login screen, we use a more robust png decoder. So it might because that the custom wallpaper is deemed as an unsafe png file so we revert to default wallpaper.
zel@ Can you reproduce with a different custom wallpaper?
Labels: Hotlist-ConOps
We're seeing a spike of reports about this from customers -- typically getting around 10 reports each day, but now have 54 reports about this within the last 24 hours.

Here's a report submitted by a Googler: https://listnr.corp.google.com/product/208/report/71439770329

Let me know if you want me to reach out to him for the wallpaper he's using that causes this issue.
Also, 72% of the reports are from folks with managed devices. Devices affected are mainly Candy, Kip, Kefka, Terra, Celes, and Reks.

Users reporting this issue are mostly on 59.0.3071.134 (40%) and 60.0.3112.80 (18%).

Comment 19 by x...@chromium.org, Aug 28 2017

I don't think that the wallpapers the customers were using are special giving the spike of reports. I found a scenario to repro the lost wallpaper in lockscreen in comment#15 and have a fix for it, but I'm not sure it's the cause that caused all the reports we're seeing here.

trumbull@, could you point to me the place I can see all the reports?  Maybe I can look through these reports. I didn't find anything new from the report that you linked in comment#17. 
@xdai Here's all the reports in the last 28 days that included PSD (device, build, etc) info: https://docs.google.com/a/google.com/spreadsheets/d/1anMC0D4QXICL9wNz2IuI5r0iYSgjbnoJ_vTGr2gTGMk/edit

We're tracking these reports under "#issue>Settings>Appearance>CantChangeWallpaper", which may include some other wallpaper issues.

We have had 64 reports with PSD info and 382 total reports in the last 28 days [last month we had 137 reports total].

Comment 22 by x...@chromium.org, Aug 30 2017

Labels: Merge-Request-61
Project Member

Comment 23 by sheriffbot@chromium.org, Aug 30 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a284146a7753e50a0d64b948865f15d9d5ab7436

commit a284146a7753e50a0d64b948865f15d9d5ab7436
Author: Mike Wittman <wittman@chromium.org>
Date: Wed Aug 30 18:34:25 2017

Revert "Do not set default wallpaper unless it should do so."

This reverts commit f838f7f543ab39ace829f5836abec0383ecb65c2.

Reason for revert: causing Linux Chromium OS ASan LSan Tests failures.

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23349

Original change's description:
> Do not set default wallpaper unless it should do so.
> 
> Bug:  751382 
> Change-Id: I4b3c38ef707ad6f6c6920eec9f0d2b13e054a941
> Reviewed-on: https://chromium-review.googlesource.com/619754
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Biao She <bshe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498325}

TBR=bshe@chromium.org,alemate@chromium.org,xdai@chromium.org

Change-Id: I58871e4a5433a108a0df96a9fddb059cbd36f73d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  751382 
Reviewed-on: https://chromium-review.googlesource.com/644166
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498543}
[modify] https://crrev.com/a284146a7753e50a0d64b948865f15d9d5ab7436/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/a284146a7753e50a0d64b948865f15d9d5ab7436/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/a284146a7753e50a0d64b948865f15d9d5ab7436/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/a284146a7753e50a0d64b948865f15d9d5ab7436/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/a284146a7753e50a0d64b948865f15d9d5ab7436/components/wallpaper/wallpaper_manager_base.h

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 31 2017

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4087620207c97d82b13902482d70629d5b3648ce

commit 4087620207c97d82b13902482d70629d5b3648ce
Author: xdai <xdai@chromium.org>
Date: Fri Sep 01 17:25:13 2017

[Merge to M61] Do not set default wallpaper unless it should do so.

TBR=bshe@chromium.org, alemate@chromium.org

(cherry picked from commit 39595f8d4dffcb644d438106dcb64a30c139ff0e)

Bug:  751382 
Change-Id: Id0793dfe467f737526a95b1e66ed01fbb8860bda
Reviewed-on: https://chromium-review.googlesource.com/619754
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#498325}
Reviewed-on: https://chromium-review.googlesource.com/646430
Cr-Original-Commit-Position: refs/heads/master@{#498982}
Reviewed-on: https://chromium-review.googlesource.com/648070
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1066}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4087620207c97d82b13902482d70629d5b3648ce/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/4087620207c97d82b13902482d70629d5b3648ce/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/4087620207c97d82b13902482d70629d5b3648ce/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/4087620207c97d82b13902482d70629d5b3648ce/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/4087620207c97d82b13902482d70629d5b3648ce/components/wallpaper/wallpaper_manager_base.h

Comment 28 by x...@chromium.org, Sep 5 2017

Labels: -ReleaseBlock-Stable
Remove RBS since there is no repro steps to consistently repro this issue. 

The fix in #26 is a speculative fix so I'll still keep this issue open.

Comment 29 Deleted

Comment 30 Deleted

If under your admin console device settings you have "Show user names and photos on the sign-in screen" set to "Always show user names and photos" and you have multiple accounts on a CB, the wallpaper at the login screen is still blurred unfortunately. Not sure if that is in the works, but I don't think it is.  For devices set to "Never show user names and photos" the wallpaper at the login screen should no longer be blurred from v64 and up. I would love the wallpaper to never be blurred in either scenario please!

Comment 32 by x...@chromium.org, Mar 19 2018

Status: Fixed (was: Assigned)
wzang@: Is the scenario described in #31 expected? 
Haven't seen similar reports for a long time, close it.

Comment 33 by wzang@chromium.org, Mar 19 2018

Re #31, the login wallpaper will still be blurred even when the device is set to "Never show user names and photos". The only time that the wallpaper is not blurred at login is when it is set from device policy in admin console.
We have it assigned from the Admin Console, and it is still blurry for me. This setting was in place before OS v64 was released however, so maybe something is stuck from earlier. I will test with a different device assigned wallpaper and get back to you. I assigned it now, but it still hasn't come down but I know it can take 24 hours to propagate.
Ok, took a little less time. That seems to have done the trick. So in either scenario now, the wallpaper is NOT blurred, which is what I was looking for. Thanks!

Sign in to add a comment